From: Suman Anna <s-anna@ti.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Suman Anna <s-anna@ti.com>
Subject: [PATCH 09/13] rpmsg: remove pointless OOM prints
Date: Fri, 12 Aug 2016 18:42:24 -0500 [thread overview]
Message-ID: <20160812234228.39731-10-s-anna@ti.com> (raw)
In-Reply-To: <20160812234228.39731-1-s-anna@ti.com>
These types of error prints are superfluous. The system will
pick up on OOM issues and let the user know. While at this,
fix the usage of using a structure instead of the actual
variable in one of the allocations.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
drivers/rpmsg/virtio_rpmsg_bus.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
index fe03b2aef450..1dbe756a987d 100644
--- a/drivers/rpmsg/virtio_rpmsg_bus.c
+++ b/drivers/rpmsg/virtio_rpmsg_bus.c
@@ -220,10 +220,8 @@ static struct rpmsg_endpoint *__rpmsg_create_ept(struct virtproc_info *vrp,
struct device *dev = rpdev ? &rpdev->dev : &vrp->vdev->dev;
ept = kzalloc(sizeof(*ept), GFP_KERNEL);
- if (!ept) {
- dev_err(dev, "failed to kzalloc a new ept\n");
+ if (!ept)
return NULL;
- }
kref_init(&ept->refcount);
mutex_init(&ept->cb_lock);
@@ -514,11 +512,9 @@ static struct rpmsg_channel *rpmsg_create_channel(struct virtproc_info *vrp,
return NULL;
}
- rpdev = kzalloc(sizeof(struct rpmsg_channel), GFP_KERNEL);
- if (!rpdev) {
- pr_err("kzalloc failed\n");
+ rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL);
+ if (!rpdev)
return NULL;
- }
rpdev->vrp = vrp;
rpdev->src = chinfo->src;
--
2.9.0
next prev parent reply other threads:[~2016-08-12 23:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 23:42 [PATCH 00/13] various remoteproc/rpmsg trivial cleanups Suman Anna
2016-08-12 23:42 ` [PATCH 01/13] remoteproc: use proper format-specifier for printing dma_addr_t Suman Anna
2016-08-12 23:42 ` [PATCH 02/13] remoteproc: fix couple of minor typos Suman Anna
2016-08-12 23:42 ` [PATCH 03/13] remoteproc: use variable names for sizeof() operator Suman Anna
2016-08-12 23:42 ` [PATCH 04/13] remoteproc: fix bare unsigned type usage Suman Anna
2016-08-12 23:42 ` [PATCH 05/13] remoteproc: align code with open parenthesis Suman Anna
2016-08-12 23:42 ` [PATCH 06/13] remoteproc: print hex numbers with a leading 0x format Suman Anna
2016-08-12 23:42 ` [PATCH 07/13] remoteproc/omap: fix various code formatting issues Suman Anna
2016-08-12 23:42 ` [PATCH 08/13] remoteproc/omap: revise a minor error trace message Suman Anna
2016-08-12 23:42 ` Suman Anna [this message]
2016-08-12 23:42 ` [PATCH 10/13] rpmsg: use proper format-specifier for printing dma_addr_t Suman Anna
2016-08-12 23:42 ` [PATCH 11/13] rpmsg: align code with open parenthesis Suman Anna
2016-08-12 23:42 ` [PATCH 12/13] rpmsg: use dynamic_hex_dump for hex dump traces Suman Anna
2016-08-12 23:42 ` [PATCH 13/13] samples/rpmsg: add support for multiple instances Suman Anna
2016-08-13 5:10 ` [PATCH 00/13] various remoteproc/rpmsg trivial cleanups Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812234228.39731-10-s-anna@ti.com \
--to=s-anna@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®