mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	<linux-remoteproc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Suman Anna <s-anna@ti.com>
Subject: [PATCH 08/13] remoteproc/omap: revise a minor error trace message
Date: Fri, 12 Aug 2016 18:42:23 -0500	[thread overview]
Message-ID: <20160812234228.39731-9-s-anna@ti.com> (raw)
In-Reply-To: <20160812234228.39731-1-s-anna@ti.com>

The omap_mbox_msg_send() is the legacy API for sending a mailbox
message. It has been replaced with the mbox_send_message() from
the mailbox framework. Revise the failure trace to print a generic
failure message instead of referencing the actual function name.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 drivers/remoteproc/omap_remoteproc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
index ddc1a12d75e0..01e234cb9157 100644
--- a/drivers/remoteproc/omap_remoteproc.c
+++ b/drivers/remoteproc/omap_remoteproc.c
@@ -96,7 +96,8 @@ static void omap_rproc_kick(struct rproc *rproc, int vqid)
 	/* send the index of the triggered virtqueue in the mailbox payload */
 	ret = mbox_send_message(oproc->mbox, (void *)vqid);
 	if (ret < 0)
-		dev_err(dev, "omap_mbox_msg_send failed: %d\n", ret);
+		dev_err(dev, "failed to send mailbox message, status = %d\n",
+			ret);
 }
 
 /*
-- 
2.9.0

  parent reply	other threads:[~2016-08-12 23:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12 23:42 [PATCH 00/13] various remoteproc/rpmsg trivial cleanups Suman Anna
2016-08-12 23:42 ` [PATCH 01/13] remoteproc: use proper format-specifier for printing dma_addr_t Suman Anna
2016-08-12 23:42 ` [PATCH 02/13] remoteproc: fix couple of minor typos Suman Anna
2016-08-12 23:42 ` [PATCH 03/13] remoteproc: use variable names for sizeof() operator Suman Anna
2016-08-12 23:42 ` [PATCH 04/13] remoteproc: fix bare unsigned type usage Suman Anna
2016-08-12 23:42 ` [PATCH 05/13] remoteproc: align code with open parenthesis Suman Anna
2016-08-12 23:42 ` [PATCH 06/13] remoteproc: print hex numbers with a leading 0x format Suman Anna
2016-08-12 23:42 ` [PATCH 07/13] remoteproc/omap: fix various code formatting issues Suman Anna
2016-08-12 23:42 ` Suman Anna [this message]
2016-08-12 23:42 ` [PATCH 09/13] rpmsg: remove pointless OOM prints Suman Anna
2016-08-12 23:42 ` [PATCH 10/13] rpmsg: use proper format-specifier for printing dma_addr_t Suman Anna
2016-08-12 23:42 ` [PATCH 11/13] rpmsg: align code with open parenthesis Suman Anna
2016-08-12 23:42 ` [PATCH 12/13] rpmsg: use dynamic_hex_dump for hex dump traces Suman Anna
2016-08-12 23:42 ` [PATCH 13/13] samples/rpmsg: add support for multiple instances Suman Anna
2016-08-13  5:10 ` [PATCH 00/13] various remoteproc/rpmsg trivial cleanups Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160812234228.39731-9-s-anna@ti.com \
    --to=s-anna@ti.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®