From: Greg KH <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: vadimp@mellanox.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, davem@davemloft.net, geert@linux-m68k.org,
akpm@linux-foundation.org, kvalo@codeaurora.org,
mchehab@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox systems platform
Date: Mon, 12 Sep 2016 08:11:38 +0200 [thread overview]
Message-ID: <20160912061138.GA11230@kroah.com> (raw)
In-Reply-To: <4e3f6ebf-2c14-6872-6a74-35da891b66be@roeck-us.net>
On Sun, Sep 11, 2016 at 10:34:27PM -0700, Guenter Roeck wrote:
> > +static int mlxplat_lpc_config(struct mlxplat_priv *priv)
> > +{
> > + struct pci_dev *pdev = NULL;
> > + u16 dev_id;
> > + int err;
> > +
> > + pdev = pci_get_bus_and_slot(MLXPLAT_CPLD_LPC_CTRL_IFC_BUS_ID,
> > + PCI_DEVFN(MLXPLAT_CPLD_LPC_CTRL_IFC_SLOT_ID,
> > + MLXPLAT_CPLD_LPC_CTRL_IFC_FUNC_ID));
> > +
>
> Kind of unusual way to initialize a PCI device. If this can't be implemented
> as PCI driver, maybe it should be initialized using PCI quirks ?
That's a _very old_ way of writing a pci driver, I thought we had gotten
rid of all of that crud.
This needs to be a "normal" PCI driver, no need for it to be a platform
driver at all from what I can tell.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-12 6:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 6:29 vadimp
2016-09-12 4:41 ` H. Peter Anvin
2016-09-12 4:52 ` Vadim Pasternak
2016-09-12 5:34 ` Guenter Roeck
2016-09-12 6:11 ` Greg KH [this message]
2016-09-12 6:12 ` Greg KH
2016-09-12 6:44 ` Vadim Pasternak
2016-09-12 7:04 ` Greg KH
2016-09-12 7:23 ` Vadim Pasternak
2016-09-12 7:40 ` Greg KH
2016-09-12 7:48 ` Vadim Pasternak
2016-09-12 8:17 ` Greg KH
2016-09-12 8:21 ` Vadim Pasternak
2016-09-12 8:34 ` Greg KH
2016-09-12 8:44 ` Vadim Pasternak
2016-09-12 9:14 ` Geert Uytterhoeven
2016-09-12 10:21 ` Greg KH
2016-09-12 10:55 ` Geert Uytterhoeven
2016-09-12 11:00 ` Ingo Molnar
2016-09-13 7:27 ` Vadim Pasternak
2016-09-13 8:12 ` Greg KH
2016-09-13 8:18 ` Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912061138.GA11230@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=jiri@resnulli.us \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vadimp@mellanox.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome