From: Greg KH <gregkh@linuxfoundation.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>
Subject: Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox systems platform
Date: Tue, 13 Sep 2016 10:12:12 +0200 [thread overview]
Message-ID: <20160913081212.GA15715@kroah.com> (raw)
In-Reply-To: <AM5PR0501MB20978EA0F1FF7A2E5162EC8FA2FE0@AM5PR0501MB2097.eurprd05.prod.outlook.com>
On Tue, Sep 13, 2016 at 07:27:20AM +0000, Vadim Pasternak wrote:
>
>
> > -----Original Message-----
> > From: Ingo Molnar [mailto:mingo.kernel.org@gmail.com] On Behalf Of Ingo
> > Molnar
> > Sent: Monday, September 12, 2016 2:01 PM
> > To: Greg KH <gregkh@linuxfoundation.org>
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>; Vadim Pasternak
> > <vadimp@mellanox.com>; tglx@linutronix.de; mingo@redhat.com;
> > hpa@zytor.com; davem@davemloft.net; akpm@linux-foundation.org;
> > kvalo@codeaurora.org; mchehab@kernel.org; linux@roeck-us.net;
> > x86@kernel.org; linux-kernel@vger.kernel.org; platform-driver-
> > x86@vger.kernel.org; jiri@resnulli.us
> > Subject: Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox
> > systems platform
> >
> >
> > * Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > > On Mon, Sep 12, 2016 at 11:14:26AM +0200, Geert Uytterhoeven wrote:
> > > > On Mon, Sep 12, 2016 at 10:34 AM, Greg KH <gregkh@linuxfoundation.org>
> > wrote:
> > > > >> This is LPC to I2C bridge.
> > > > >
> > > > > "LPC"?
> > > >
> > > > https://en.wikipedia.org/wiki/Low_Pin_Count
> > > >
> > > > "Modern ISA"
> > >
> > > So my original point stands, 1990's technology being used for brand
> > > new devices today, ugh :(
> > >
> > > Someone needs to go kick some hardware designers...
> >
> > In their defense, "this is a carbon copy of published 1990s technology" is a pretty
> > good starting point for a defendant, in patent litigation.
> >
>
> I understood your comments regarding undiscoverable busses.
> But we use LPC on all our x86 based systems.
> I have to activate all platform related stuff from some place and we
> don't support ACPI.
x86 that doesn't support ACPI? That's sad :(
> Do you think it would be OK, if I'll remove all PCI related code, make
> use of DMI and leave only platform activation code?
> If yes, I'll re-work this driver and re-send it for your review.
Yes, that sounds like a good start, let's see how the code looks after
doing that.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-13 8:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 6:29 vadimp
2016-09-12 4:41 ` H. Peter Anvin
2016-09-12 4:52 ` Vadim Pasternak
2016-09-12 5:34 ` Guenter Roeck
2016-09-12 6:11 ` Greg KH
2016-09-12 6:12 ` Greg KH
2016-09-12 6:44 ` Vadim Pasternak
2016-09-12 7:04 ` Greg KH
2016-09-12 7:23 ` Vadim Pasternak
2016-09-12 7:40 ` Greg KH
2016-09-12 7:48 ` Vadim Pasternak
2016-09-12 8:17 ` Greg KH
2016-09-12 8:21 ` Vadim Pasternak
2016-09-12 8:34 ` Greg KH
2016-09-12 8:44 ` Vadim Pasternak
2016-09-12 9:14 ` Geert Uytterhoeven
2016-09-12 10:21 ` Greg KH
2016-09-12 10:55 ` Geert Uytterhoeven
2016-09-12 11:00 ` Ingo Molnar
2016-09-13 7:27 ` Vadim Pasternak
2016-09-13 8:12 ` Greg KH [this message]
2016-09-13 8:18 ` Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913081212.GA15715@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=jiri@resnulli.us \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vadimp@mellanox.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome