From: Greg KH <gregkh@linuxfoundation.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
jsimmons@infradead.org, john.hammond@intel.com,
shraddha.6596@gmail.com, di.wang@intel.com,
ksenija.stanojevic@gmail.com, mike.rapoport@gmail.com,
andrew.perepechko@seagate.com, kirill.shutemov@linux.intel.com,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org,
arnd@arndb.de
Subject: Re: [PATCH] staging: lustre: clean function declarations in class_obd.c up
Date: Thu, 15 Sep 2016 16:52:38 +0200 [thread overview]
Message-ID: <20160915145238.GB26016@kroah.com> (raw)
In-Reply-To: <1473947487-25514-1-git-send-email-baoyou.xie@linaro.org>
On Thu, Sep 15, 2016 at 09:51:27PM +0800, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
Don't do that! :)
>
> drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for 'class_procfs_clean' [-Wmissing-prototypes]
>
> In fact, both functions are declared in
> drivers/staging/lustre/lustre/obdclass/class_obd.c,but should be
> declared in a header file, thus can be recognized in other file.
>
> So this patch moves the declarations into
> drivers/staging/lustre/lustre/include/obd_class.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/staging/lustre/lustre/include/obd_class.h | 4 ++++
> drivers/staging/lustre/lustre/obdclass/class_obd.c | 2 --
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
> index 9702ad4..9965a01 100644
> --- a/drivers/staging/lustre/lustre/include/obd_class.h
> +++ b/drivers/staging/lustre/lustre/include/obd_class.h
> @@ -1712,6 +1712,10 @@ int class_check_uuid(struct obd_uuid *uuid, __u64 nid);
> void class_init_uuidlist(void);
> void class_exit_uuidlist(void);
>
> +/*linux-module.c*/
Here, have a ' '. make that two...
thanks,
greg k-h
prev parent reply other threads:[~2016-09-15 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 13:51 Baoyou Xie
2016-09-15 14:52 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915145238.GB26016@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=andrew.perepechko@seagate.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=di.wang@intel.com \
--cc=john.hammond@intel.com \
--cc=jsimmons@infradead.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=ksenija.stanojevic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=mike.rapoport@gmail.com \
--cc=oleg.drokin@intel.com \
--cc=shraddha.6596@gmail.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®