[PATCH] staging: lustre: clean function declarations in class_obd.c up

[PATCH] staging: lustre: clean function declarations in class_obd.c up

[Baoyou Xie]

We get 2 warnings when building kernel with W=1:

drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes]
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for 'class_procfs_clean' [-Wmissing-prototypes]

In fact, both functions are declared in
drivers/staging/lustre/lustre/obdclass/class_obd.c,but should be
declared in a header file, thus can be recognized in other file.

So this patch moves the declarations into
drivers/staging/lustre/lustre/include/obd_class.h.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/staging/lustre/lustre/include/obd_class.h  | 4 ++++
 drivers/staging/lustre/lustre/obdclass/class_obd.c | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
index 9702ad4..9965a01 100644
--- a/drivers/staging/lustre/lustre/include/obd_class.h
+++ b/drivers/staging/lustre/lustre/include/obd_class.h
@@ -1712,6 +1712,10 @@ int class_check_uuid(struct obd_uuid *uuid, __u64 nid);
 void class_init_uuidlist(void);
 void class_exit_uuidlist(void);
 
+/*linux-module.c*/
+int class_procfs_init(void);
+int class_procfs_clean(void);
+
 /* class_obd.c */
 extern char obd_jobid_node[];
 extern struct miscdevice obd_psdev;
diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/class_obd.c
index 6700167..397929a 100644
--- a/drivers/staging/lustre/lustre/obdclass/class_obd.c
+++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c
@@ -446,8 +446,6 @@ static int obd_init_checks(void)
 	return ret;
 }
 
-extern int class_procfs_init(void);
-extern int class_procfs_clean(void);
 
 static int __init obdclass_init(void)
 {
-- 
2.7.4

Re: [PATCH] staging: lustre: clean function declarations in class_obd.c up

[Greg KH]

On Thu, Sep 15, 2016 at 09:51:27PM +0800, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:

Don't do that!  :)

> 
> drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for 'class_procfs_clean' [-Wmissing-prototypes]
> 
> In fact, both functions are declared in
> drivers/staging/lustre/lustre/obdclass/class_obd.c,but should be
> declared in a header file, thus can be recognized in other file.
> 
> So this patch moves the declarations into
> drivers/staging/lustre/lustre/include/obd_class.h.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/staging/lustre/lustre/include/obd_class.h  | 4 ++++
>  drivers/staging/lustre/lustre/obdclass/class_obd.c | 2 --
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
> index 9702ad4..9965a01 100644
> --- a/drivers/staging/lustre/lustre/include/obd_class.h
> +++ b/drivers/staging/lustre/lustre/include/obd_class.h
> @@ -1712,6 +1712,10 @@ int class_check_uuid(struct obd_uuid *uuid, __u64 nid);
>  void class_init_uuidlist(void);
>  void class_exit_uuidlist(void);
>  
> +/*linux-module.c*/

Here, have a ' '.  make that two...

thanks,

greg k-h