From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Baolin Wang <baolin.wang@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Ingo Molnar <mingo@redhat.com>,
John Stultz <john.stultz@linaro.org>,
Mark Brown <broonie@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH 2/2] time: alarmtimer: Add the trcepoints for alarmtimer
Date: Wed, 21 Sep 2016 09:32:55 -0400 [thread overview]
Message-ID: <20160921093255.5b398d6c@gandalf.local.home> (raw)
In-Reply-To: <alpine.DEB.2.20.1609211435050.5573@nanos>
On Wed, 21 Sep 2016 14:36:23 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 21 Sep 2016, Steven Rostedt wrote:
> > On Wed, 21 Sep 2016 09:26:20 +0200 (CEST)
> > Thomas Gleixner <tglx@linutronix.de> wrote:
> > > A single u64 does not take more storage space than this and it's a single
> > > store.
> >
> > So to use rtc_tm_to_time64()? Is the work to do the calculations of the
> > conversion faster than a bunch of stores that are going to be in hot
> > cache?
>
> Look at the call site. It has already the scalar nsec value and it does a
> conversion to rtc time in order to trace it.
OK. I haven't looked at the callsite. I just did a quick look at the
patch as is, and noticed the wasted space in the buffer for storing a
bunch of ints that will never be bigger than 256.
>
> Ditto for the other tracepoints where the conversion from scalar nsec is
> done in the tracepoint itself.
This is why I like to have the maintainers review the rest.
-- Steve
next prev parent reply other threads:[~2016-09-21 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 6:03 [PATCH 1/2] rtc: Add some dummy static inline functions Baolin Wang
2016-09-18 6:03 ` [PATCH 2/2] time: alarmtimer: Add the trcepoints for alarmtimer Baolin Wang
2016-09-20 22:27 ` Thomas Gleixner
2016-09-21 3:25 ` Baolin Wang
2016-09-21 7:26 ` Thomas Gleixner
2016-09-21 10:58 ` Baolin Wang
2016-09-21 12:33 ` Steven Rostedt
2016-09-21 12:36 ` Thomas Gleixner
2016-09-21 13:32 ` Steven Rostedt [this message]
2016-09-20 21:36 ` [PATCH 1/2] rtc: Add some dummy static inline functions Thomas Gleixner
2016-09-21 2:01 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921093255.5b398d6c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®