mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
	rostedt@goodmis.org, mingo@redhat.com, john.stultz@linaro.org,
	broonie@kernel.org, linux-kernel@vger.kernel.org,
	rtc-linux@googlegroups.com
Subject: Re: [PATCH 1/2] rtc: Add some dummy static inline functions
Date: Tue, 20 Sep 2016 23:36:10 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609202333220.5476@nanos> (raw)
In-Reply-To: <8c570c152c95087faa75e397c667b6d5b8d98b3b.1474177609.git.baolin.wang@linaro.org>

On Sun, 18 Sep 2016, Baolin Wang wrote:

> The patch 2 in this patchset adding tracepoints for alarmtimers will build
> failed on S390 platform, due to S390 defconfig did not define CONFIG_RTC_LIB
> macro to define the rtc_ktime_to_tm() function which is used in this patch.
> Thus we should add some ummy static inline functions in case CONFIG_RTC_LIB
> is not defined.

I told you before that adding these inlines has the danger that we
introduce code which uses these functions in places which does not depend
on RTC_LIB. The resulting wreckage is going to be subtle and hard to debug.

This still stands and this patch is going nowhere.

Thanks,

	tglx

  parent reply	other threads:[~2016-09-20 21:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-18  6:03 Baolin Wang
2016-09-18  6:03 ` [PATCH 2/2] time: alarmtimer: Add the trcepoints for alarmtimer Baolin Wang
2016-09-20 22:27   ` Thomas Gleixner
2016-09-21  3:25     ` Baolin Wang
2016-09-21  7:26       ` Thomas Gleixner
2016-09-21 10:58         ` Baolin Wang
2016-09-21 12:33         ` Steven Rostedt
2016-09-21 12:36           ` Thomas Gleixner
2016-09-21 13:32             ` Steven Rostedt
2016-09-20 21:36 ` Thomas Gleixner [this message]
2016-09-21  2:01   ` [PATCH 1/2] rtc: Add some dummy static inline functions Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609202333220.5476@nanos \
    --to=tglx@linutronix.de \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=baolin.wang@linaro.org \
    --cc=broonie@kernel.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®