From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, huangdaode@hisilicon.com,
lisheng011@huawei.com, xieqianqian@huawei.com, fabf@skynet.be,
oulijun@huawei.com, vinod.koul@intel.com, lipeng321@huawei.com,
andrew@lunn.ch, tremyfr@gmail.com, chenny.xu@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xie.baoyou@zte.com.cn, han.fei@zte.com.cn,
tang.qiang007@zte.com.cn
Subject: Re: [PATCH 2/2] net: hns: add missing function declaration
Date: Fri, 30 Sep 2016 16:32:24 +0200 [thread overview]
Message-ID: <201609301632.24678.arnd@arndb.de> (raw)
In-Reply-To: <1475221315-18602-1-git-send-email-baoyou.xie@linaro.org>
On Friday 30 September 2016, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2784:5: warning: no previous prototype for 'hns_dsaf_roce_reset' [-Wmissing-prototypes]
>
> In fact, this function is not declared in any file, but should be
> declared in a header file. thus can be recognized in other file.
>
> so this patch adds the missing function declaration into
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
If you get to a case like this, please describe in the changelog how you determined that
the function is there intentionally, rather than something that should be removed?
I also see that you had sent the patch series for hns previously, and had included
a 'v2' version in the subject, but left out the version this time. Please always
use increasing version numbers when you send a new version of the series.
Arnd
prev parent reply other threads:[~2016-09-30 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 7:41 Baoyou Xie
2016-09-30 14:32 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201609301632.24678.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=baoyou.xie@linaro.org \
--cc=chenny.xu@huawei.com \
--cc=davem@davemloft.net \
--cc=fabf@skynet.be \
--cc=han.fei@zte.com.cn \
--cc=huangdaode@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=salil.mehta@huawei.com \
--cc=tang.qiang007@zte.com.cn \
--cc=tremyfr@gmail.com \
--cc=vinod.koul@intel.com \
--cc=xie.baoyou@zte.com.cn \
--cc=xieqianqian@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome