[PATCH 2/2] net: hns: add missing function declaration

[PATCH 2/2] net: hns: add missing function declaration

[Baoyou Xie]

We get 1 warning when building kernel with W=1:
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2784:5: warning: no previous prototype for 'hns_dsaf_roce_reset' [-Wmissing-prototypes]

In fact, this function is not declared in any file, but should be
declared in a header file. thus can be recognized in other file.

so this patch adds the missing function declaration into
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
index f3681d5..c655ecb 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
@@ -449,7 +449,10 @@ void hns_dsaf_srst_chns(struct dsaf_device *dsaf_dev, u32 msk, bool enable);
 
 void hns_dsaf_roce_srst(struct dsaf_device *dsaf_dev, bool enable);
 
+int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool enable);
+
 int hns_dsaf_ae_init(struct dsaf_device *dsaf_dev);
+
 void hns_dsaf_ae_uninit(struct dsaf_device *dsaf_dev);
 
 void hns_dsaf_update_stats(struct dsaf_device *dsaf_dev, u32 inode_num);
-- 
2.7.4

Re: [PATCH 2/2] net: hns: add missing function declaration

[Arnd Bergmann]

On Friday 30 September 2016, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2784:5: warning: no previous prototype for 'hns_dsaf_roce_reset' [-Wmissing-prototypes]
> 
> In fact, this function is not declared in any file, but should be
> declared in a header file. thus can be recognized in other file.
> 
> so this patch adds the missing function declaration into
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

If you get to a case like this, please describe in the changelog how you determined that
the function is there intentionally, rather than something that should be removed?

I also see that you had sent the patch series for hns previously, and had included
a 'v2' version in the subject, but left out the version this time. Please always
use increasing version numbers when you send a new version of the series.

	Arnd