mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolai Stange <nicstange@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: John Stultz <john.stultz@linaro.org>,
	linux-kernel@vger.kernel.org,
	Nicolai Stange <nicstange@gmail.com>
Subject: [RFC v8 15/28] clockevents: use ->min_delta_ticks_adjusted to program minimum delta
Date: Sat, 19 Nov 2016 17:10:23 +0100	[thread overview]
Message-ID: <20161119161036.12679-4-nicstange@gmail.com> (raw)
In-Reply-To: <20161119160055.12491-1-nicstange@gmail.com>

The use of a clockevent device's ->min_delta_ns in the event programming
path hinders upcoming changes to the clockevent core making it NTP
correction aware: both, ->mult and ->min_delta_ns would need to get
updated as well as consumed atomically and we'd rather like to avoid any
locking here.

We already have got ->min_delta_ticks_adjusted which
- resembles the value of ->min_delta_ns
- and is guaranteed to be always >= the hardware's hard limit
  ->min_delta_ticks and thus, can be used w/o locking as we don't care
  for small deviations.

In both implementations of clockevents_program_min_delta(),
don't calculate the event's deadline from ->min_delta_ns, but use its
drop-in replacement ->min_delta_ticks_adjusted.

Signed-off-by: Nicolai Stange <nicstange@gmail.com>
---
 kernel/time/clockevents.c | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 8d32c2c..74b05dd 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -243,19 +243,14 @@ static int clockevents_increase_min_delta(struct clock_event_device *dev)
  */
 static int clockevents_program_min_delta(struct clock_event_device *dev)
 {
-	unsigned long long clc;
-	int64_t delta;
 	int i;
 
 	for (i = 0;;) {
-		delta = dev->min_delta_ns;
-
 		if (clockevent_state_shutdown(dev))
 			return 0;
 
 		dev->retries++;
-		clc = ((unsigned long long) delta * dev->mult) >> dev->shift;
-		if (dev->set_next_event((unsigned long) clc, dev) == 0)
+		if (!dev->set_next_event(dev->min_delta_ticks_adjusted, dev))
 			return 0;
 
 		if (++i > 2) {
@@ -281,17 +276,11 @@ static int clockevents_program_min_delta(struct clock_event_device *dev)
  */
 static int clockevents_program_min_delta(struct clock_event_device *dev)
 {
-	unsigned long long clc;
-	int64_t delta;
-
-	delta = dev->min_delta_ns;
-
 	if (clockevent_state_shutdown(dev))
 		return 0;
 
 	dev->retries++;
-	clc = ((unsigned long long) delta * dev->mult) >> dev->shift;
-	return dev->set_next_event((unsigned long) clc, dev);
+	return dev->set_next_event(dev->min_delta_ticks_adjusted, dev);
 }
 
 #endif /* CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST */
-- 
2.10.2

  parent reply	other threads:[~2016-11-19 16:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-19 16:00 [RFC v8 00/28] adapt clockevents frequencies to mono clock Nicolai Stange
2016-11-19 16:00 ` [RFC v8 01/28] clocksource: sh_cmt: compute rate before registration again Nicolai Stange
2016-11-19 16:00 ` [RFC v8 02/28] clocksource: sh_tmu: " Nicolai Stange
2016-11-19 16:00 ` [RFC v8 03/28] clocksource: em_sti: split clock prepare and enable steps Nicolai Stange
2016-11-19 16:00 ` [RFC v8 04/28] clocksource: em_sti: compute rate before registration Nicolai Stange
2016-11-19 16:00 ` [RFC v8 05/28] clocksource: h8300_timer8: don't reset rate in ->set_state_oneshot() Nicolai Stange
2016-11-19 16:00 ` [RFC v8 06/28] clockevents: make clockevents_config() static Nicolai Stange
2016-11-19 16:00 ` [RFC v8 07/28] many clockevent drivers: set ->min_delta_ticks and ->max_delta_ticks Nicolai Stange
2016-11-19 16:00 ` [RFC v8 08/28] arch/s390/kernel/time: " Nicolai Stange
2016-11-19 16:00 ` [RFC v8 09/28] arch/x86/platform/uv/uv_time: " Nicolai Stange
2016-11-19 16:00 ` [RFC v8 10/28] arch/tile/kernel/time: " Nicolai Stange
2016-11-19 16:00 ` [RFC v8 11/28] clockevents: always initialize ->min_delta_ns and ->max_delta_ns Nicolai Stange
2016-11-19 16:10 ` [RFC v8 12/28] many clockevent drivers: don't set " Nicolai Stange
2016-11-19 16:10 ` [RFC v8 13/28] clockevents: do comparison of delta against minimum in terms of cycles Nicolai Stange
2016-11-19 16:10 ` [RFC v8 14/28] clockevents: clockevents_program_min_delta(): don't set ->next_event Nicolai Stange
2016-11-19 16:10 ` Nicolai Stange [this message]
2016-11-19 16:10 ` [RFC v8 16/28] clockevents: min delta increment: calculate min_delta_ns from ticks Nicolai Stange
2016-11-19 16:10 ` [RFC v8 17/28] timer_list: print_tickdevice(): calculate ->min_delta_ns dynamically Nicolai Stange
2016-11-19 16:10 ` [RFC v8 18/28] clockevents: purge ->min_delta_ns Nicolai Stange
2016-11-19 16:10 ` [RFC v8 19/28] clockevents: introduce CLOCK_EVT_FEAT_NO_ADJUST flag Nicolai Stange
2016-11-19 16:10 ` [RFC v8 20/28] clockevents: degrade ->min_delta_ticks to unsigned int Nicolai Stange
2016-11-19 16:10 ` [RFC v8 21/28] clockevents: pack ->state_use_accessors and ->features together Nicolai Stange
2016-11-19 16:10 ` [RFC v8 22/28] clockevents: decouple ->max_delta_ns from ->max_delta_ticks Nicolai Stange
2016-11-19 16:10 ` [RFC v8 23/28] clockevents: initial support for mono to raw time conversion Nicolai Stange
2016-11-19 16:10 ` [RFC v8 24/28] clockevents: make setting of ->mult and ->mult_adjusted atomic Nicolai Stange
2016-11-19 16:10 ` [RFC v8 25/28] timekeeping: inform clockevents about freq adjustments Nicolai Stange
2016-11-19 16:10 ` [RFC v8 26/28] clockevents: degrade ->retries to unsigned int Nicolai Stange
2016-11-19 16:10 ` [RFC v8 27/28] clockevents: optimize struct clock_event_device layout Nicolai Stange
2016-11-19 16:10 ` [RFC v8 28/28] clockevents: move non-adjustable devices to the tail of the list Nicolai Stange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161119161036.12679-4-nicstange@gmail.com \
    --to=nicstange@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®