From: Nicolai Stange <nicstange@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org,
Nicolai Stange <nicstange@gmail.com>
Subject: [RFC v8 20/28] clockevents: degrade ->min_delta_ticks to unsigned int
Date: Sat, 19 Nov 2016 17:10:28 +0100 [thread overview]
Message-ID: <20161119161036.12679-9-nicstange@gmail.com> (raw)
In-Reply-To: <20161119160055.12491-1-nicstange@gmail.com>
While being of type unsigned long right now, the ->min_delta_ticks and
->min_delta_ticks_adjusted members of struct clock_event_device aren't
expected to ever overflow an unsigned int.
The latter sits in the first cacheline. For the case of
sizeof(long) > sizeof(int), this is a waste of precious space needed by
later patches.
Degrade the types of ->min_delta_ticks_adjusted and ->min_delta_ticks
from unsigned long to unsigned int.
Change casts in the clockevents core were needed.
Adapt the signature of clockevents_config_and_register() accordingly.
Finally, move ->min_delta_ticks farther down the struct in order to
allow for alignment with other ints, potentially avoiding padding.
Signed-off-by: Nicolai Stange <nicstange@gmail.com>
---
include/linux/clockchips.h | 8 ++++----
kernel/time/clockevents.c | 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/linux/clockchips.h b/include/linux/clockchips.h
index 76fc51b..c8dfc7a 100644
--- a/include/linux/clockchips.h
+++ b/include/linux/clockchips.h
@@ -92,9 +92,9 @@ enum clock_event_state {
* @set_state_shutdown: switch state to shutdown
* @tick_resume: resume clkevt device
* @broadcast: function to broadcast events
- * @min_delta_ticks: minimum delta value in ticks stored for reconfiguration
* @max_delta_ticks: maximum delta value in ticks stored for reconfiguration
* @name: ptr to clock event name
+ * @min_delta_ticks: minimum delta value in ticks stored for reconfiguration
* @rating: variable to rate clock event devices
* @irq: IRQ number (only for non CPU local devices)
* @bound_on: Bound on CPU
@@ -108,7 +108,7 @@ struct clock_event_device {
int (*set_next_ktime)(ktime_t expires, struct clock_event_device *);
ktime_t next_event;
u64 max_delta_ns;
- unsigned long min_delta_ticks_adjusted;
+ unsigned int min_delta_ticks_adjusted;
u32 mult;
u32 shift;
enum clock_event_state state_use_accessors;
@@ -124,10 +124,10 @@ struct clock_event_device {
void (*broadcast)(const struct cpumask *mask);
void (*suspend)(struct clock_event_device *);
void (*resume)(struct clock_event_device *);
- unsigned long min_delta_ticks;
unsigned long max_delta_ticks;
const char *name;
+ unsigned int min_delta_ticks;
int rating;
int irq;
int bound_on;
@@ -189,7 +189,7 @@ extern void clockevents_register_device(struct clock_event_device *dev);
extern int clockevents_unbind_device(struct clock_event_device *ced, int cpu);
extern void clockevents_config_and_register(struct clock_event_device *dev,
- u32 freq, unsigned long min_delta,
+ u32 freq, unsigned int min_delta,
unsigned long max_delta);
extern int clockevents_update_freq(struct clock_event_device *ce, u32 freq);
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 57b00b0..84639a1 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -228,7 +228,7 @@ static int clockevents_increase_min_delta(struct clock_event_device *dev)
if (min_delta_ns > MIN_DELTA_LIMIT)
min_delta_ns = MIN_DELTA_LIMIT;
- dev->min_delta_ticks_adjusted = (unsigned long)((min_delta_ns *
+ dev->min_delta_ticks_adjusted = (unsigned int)((min_delta_ns *
dev->mult) >> dev->shift);
printk_deferred(KERN_WARNING
@@ -451,7 +451,7 @@ static void __clockevents_update_bounds(struct clock_event_device *dev)
*/
dev->min_delta_ticks_adjusted =
max(dev->min_delta_ticks,
- (unsigned long)((1000ULL * dev->mult) >> dev->shift));
+ (unsigned int)((1000ULL * dev->mult) >> dev->shift));
}
/**
@@ -514,7 +514,7 @@ static void clockevents_config(struct clock_event_device *dev, u32 freq)
* min/max_delta can be 0 for devices which do not support oneshot mode.
*/
void clockevents_config_and_register(struct clock_event_device *dev,
- u32 freq, unsigned long min_delta,
+ u32 freq, unsigned int min_delta,
unsigned long max_delta)
{
dev->min_delta_ticks = min_delta;
--
2.10.2
next prev parent reply other threads:[~2016-11-19 16:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 16:00 [RFC v8 00/28] adapt clockevents frequencies to mono clock Nicolai Stange
2016-11-19 16:00 ` [RFC v8 01/28] clocksource: sh_cmt: compute rate before registration again Nicolai Stange
2016-11-19 16:00 ` [RFC v8 02/28] clocksource: sh_tmu: " Nicolai Stange
2016-11-19 16:00 ` [RFC v8 03/28] clocksource: em_sti: split clock prepare and enable steps Nicolai Stange
2016-11-19 16:00 ` [RFC v8 04/28] clocksource: em_sti: compute rate before registration Nicolai Stange
2016-11-19 16:00 ` [RFC v8 05/28] clocksource: h8300_timer8: don't reset rate in ->set_state_oneshot() Nicolai Stange
2016-11-19 16:00 ` [RFC v8 06/28] clockevents: make clockevents_config() static Nicolai Stange
2016-11-19 16:00 ` [RFC v8 07/28] many clockevent drivers: set ->min_delta_ticks and ->max_delta_ticks Nicolai Stange
2016-11-19 16:00 ` [RFC v8 08/28] arch/s390/kernel/time: " Nicolai Stange
2016-11-19 16:00 ` [RFC v8 09/28] arch/x86/platform/uv/uv_time: " Nicolai Stange
2016-11-19 16:00 ` [RFC v8 10/28] arch/tile/kernel/time: " Nicolai Stange
2016-11-19 16:00 ` [RFC v8 11/28] clockevents: always initialize ->min_delta_ns and ->max_delta_ns Nicolai Stange
2016-11-19 16:10 ` [RFC v8 12/28] many clockevent drivers: don't set " Nicolai Stange
2016-11-19 16:10 ` [RFC v8 13/28] clockevents: do comparison of delta against minimum in terms of cycles Nicolai Stange
2016-11-19 16:10 ` [RFC v8 14/28] clockevents: clockevents_program_min_delta(): don't set ->next_event Nicolai Stange
2016-11-19 16:10 ` [RFC v8 15/28] clockevents: use ->min_delta_ticks_adjusted to program minimum delta Nicolai Stange
2016-11-19 16:10 ` [RFC v8 16/28] clockevents: min delta increment: calculate min_delta_ns from ticks Nicolai Stange
2016-11-19 16:10 ` [RFC v8 17/28] timer_list: print_tickdevice(): calculate ->min_delta_ns dynamically Nicolai Stange
2016-11-19 16:10 ` [RFC v8 18/28] clockevents: purge ->min_delta_ns Nicolai Stange
2016-11-19 16:10 ` [RFC v8 19/28] clockevents: introduce CLOCK_EVT_FEAT_NO_ADJUST flag Nicolai Stange
2016-11-19 16:10 ` Nicolai Stange [this message]
2016-11-19 16:10 ` [RFC v8 21/28] clockevents: pack ->state_use_accessors and ->features together Nicolai Stange
2016-11-19 16:10 ` [RFC v8 22/28] clockevents: decouple ->max_delta_ns from ->max_delta_ticks Nicolai Stange
2016-11-19 16:10 ` [RFC v8 23/28] clockevents: initial support for mono to raw time conversion Nicolai Stange
2016-11-19 16:10 ` [RFC v8 24/28] clockevents: make setting of ->mult and ->mult_adjusted atomic Nicolai Stange
2016-11-19 16:10 ` [RFC v8 25/28] timekeeping: inform clockevents about freq adjustments Nicolai Stange
2016-11-19 16:10 ` [RFC v8 26/28] clockevents: degrade ->retries to unsigned int Nicolai Stange
2016-11-19 16:10 ` [RFC v8 27/28] clockevents: optimize struct clock_event_device layout Nicolai Stange
2016-11-19 16:10 ` [RFC v8 28/28] clockevents: move non-adjustable devices to the tail of the list Nicolai Stange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119161036.12679-9-nicstange@gmail.com \
--to=nicstange@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®