From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-pci@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Lukas Wunner <lukas@wunner.de>, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors
Date: Mon, 21 Nov 2016 15:45:19 -0600 [thread overview]
Message-ID: <20161121214519.21036.33519.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20161121214006.21036.11599.stgit@bhelgaas-glaptop.roam.corp.google.com>
Since we register pcie_pme_driver only for PCI_EXP_TYPE_ROOT_PORT, the PME
driver never claims Root Complex Event Collectors.
Remove unused code related to Root Complex Event Collectors.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/pcie/pme.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
index 884bad5..9e8aa9d 100644
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -319,23 +319,8 @@ static int pcie_pme_set_native(struct pci_dev *dev, void *ign)
static void pcie_pme_mark_devices(struct pci_dev *port)
{
pcie_pme_set_native(port, NULL);
- if (port->subordinate) {
+ if (port->subordinate)
pci_walk_bus(port->subordinate, pcie_pme_set_native, NULL);
- } else {
- struct pci_bus *bus = port->bus;
- struct pci_dev *dev;
-
- /* Check if this is a root port event collector. */
- if (pci_pcie_type(port) != PCI_EXP_TYPE_RC_EC || !bus)
- return;
-
- down_read(&pci_bus_sem);
- list_for_each_entry(dev, &bus->devices, bus_list)
- if (pci_is_pcie(dev)
- && pci_pcie_type(dev) == PCI_EXP_TYPE_RC_END)
- pcie_pme_set_native(dev, NULL);
- up_read(&pci_bus_sem);
- }
}
/**
next prev parent reply other threads:[~2016-11-21 21:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 21:45 [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas
2016-11-21 21:45 ` Bjorn Helgaas [this message]
2016-11-21 22:28 ` [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors Rafael J. Wysocki
2016-11-21 22:42 ` Bjorn Helgaas
2016-11-21 22:58 ` Rafael J. Wysocki
2016-11-21 23:00 ` Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port Bjorn Helgaas
2016-11-21 22:29 ` Rafael J. Wysocki
2016-11-21 21:45 ` [PATCH v2 3/9] PCI/AER: Remove unused version macros Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 4/9] PCI/AER: Log errors with PCI device, not PCIe service device Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 5/9] PCI/AER: Log AER IRQ when claiming Root Port Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 6/9] PCI: Remove service driver load/unload messages Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 7/9] PCI: hotplug: Remove hotplug core message Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 8/9] PCI: pciehp: Remove loading message Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 9/9] PCI: Expand "VPD access disabled" quirk message Bjorn Helgaas
2016-11-23 17:36 ` [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121214519.21036.33519.stgit@bhelgaas-glaptop.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®