From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-pci@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Lukas Wunner <lukas@wunner.de>, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port
Date: Mon, 21 Nov 2016 15:45:26 -0600 [thread overview]
Message-ID: <20161121214526.21036.73271.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20161121214006.21036.11599.stgit@bhelgaas-glaptop.roam.corp.google.com>
We already log a "Signaling PME" whenever the PME service driver claims a
Root Port. In fact, we also log the same message for every device in the
hierarchy below the Root Port.
Log the "Signaling PME" once (only for the Root Port, since we can
trivially find out which devices are below the Root Port), and include the
IRQ number in the message to help connect the dots with /proc/interrupts.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/pcie/pme.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
index 9e8aa9d..7175293 100644
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -300,8 +300,6 @@ static irqreturn_t pcie_pme_irq(int irq, void *context)
*/
static int pcie_pme_set_native(struct pci_dev *dev, void *ign)
{
- dev_info(&dev->dev, "Signaling PME through PCIe PME interrupt\n");
-
device_set_run_wake(&dev->dev, true);
dev->pme_interrupt = true;
return 0;
@@ -349,12 +347,14 @@ static int pcie_pme_probe(struct pcie_device *srv)
ret = request_irq(srv->irq, pcie_pme_irq, IRQF_SHARED, "PCIe PME", srv);
if (ret) {
kfree(data);
- } else {
- pcie_pme_mark_devices(port);
- pcie_pme_interrupt_enable(port, true);
+ return ret;
}
- return ret;
+ dev_info(&port->dev, "Signaling PME with IRQ %d\n", srv->irq);
+
+ pcie_pme_mark_devices(port);
+ pcie_pme_interrupt_enable(port, true);
+ return 0;
}
static bool pcie_pme_check_wakeup(struct pci_bus *bus)
next prev parent reply other threads:[~2016-11-21 21:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 21:45 [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors Bjorn Helgaas
2016-11-21 22:28 ` Rafael J. Wysocki
2016-11-21 22:42 ` Bjorn Helgaas
2016-11-21 22:58 ` Rafael J. Wysocki
2016-11-21 23:00 ` Bjorn Helgaas
2016-11-21 21:45 ` Bjorn Helgaas [this message]
2016-11-21 22:29 ` [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port Rafael J. Wysocki
2016-11-21 21:45 ` [PATCH v2 3/9] PCI/AER: Remove unused version macros Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 4/9] PCI/AER: Log errors with PCI device, not PCIe service device Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 5/9] PCI/AER: Log AER IRQ when claiming Root Port Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 6/9] PCI: Remove service driver load/unload messages Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 7/9] PCI: hotplug: Remove hotplug core message Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 8/9] PCI: pciehp: Remove loading message Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 9/9] PCI: Expand "VPD access disabled" quirk message Bjorn Helgaas
2016-11-23 17:36 ` [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121214526.21036.73271.stgit@bhelgaas-glaptop.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®