mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-pci@vger.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Lukas Wunner <lukas@wunner.de>, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/9] PCI/AER: Log errors with PCI device, not PCIe service device
Date: Mon, 21 Nov 2016 15:45:41 -0600	[thread overview]
Message-ID: <20161121214541.21036.3404.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20161121214006.21036.11599.stgit@bhelgaas-glaptop.roam.corp.google.com>

All other AER-related log messages use the PCI device, e.g.,
"pci 0000:00:1c.0", not the PCIe service device, e.g.,
"aer 0000:00:1c.0:pcie02".

Change the probe error messages to match the rest and include a little
context.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/pcie/aer/aerdrv.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c
index 1c189e6..60e63d6 100644
--- a/drivers/pci/pcie/aer/aerdrv.c
+++ b/drivers/pci/pcie/aer/aerdrv.c
@@ -290,12 +290,12 @@ static int aer_probe(struct pcie_device *dev)
 {
 	int status;
 	struct aer_rpc *rpc;
-	struct device *device = &dev->device;
+	struct device *device = &dev->port->dev;
 
 	/* Alloc rpc data structure */
 	rpc = aer_alloc_rpc(dev);
 	if (!rpc) {
-		dev_printk(KERN_DEBUG, device, "alloc rpc failed\n");
+		dev_printk(KERN_DEBUG, device, "alloc AER rpc failed\n");
 		aer_remove(dev);
 		return -ENOMEM;
 	}
@@ -303,7 +303,8 @@ static int aer_probe(struct pcie_device *dev)
 	/* Request IRQ ISR */
 	status = request_irq(dev->irq, aer_irq, IRQF_SHARED, "aerdrv", dev);
 	if (status) {
-		dev_printk(KERN_DEBUG, device, "request IRQ failed\n");
+		dev_printk(KERN_DEBUG, device, "request AER IRQ %d failed\n",
+			   dev->irq);
 		aer_remove(dev);
 		return status;
 	}

  parent reply	other threads:[~2016-11-21 21:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21 21:45 [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors Bjorn Helgaas
2016-11-21 22:28   ` Rafael J. Wysocki
2016-11-21 22:42     ` Bjorn Helgaas
2016-11-21 22:58       ` Rafael J. Wysocki
2016-11-21 23:00         ` Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port Bjorn Helgaas
2016-11-21 22:29   ` Rafael J. Wysocki
2016-11-21 21:45 ` [PATCH v2 3/9] PCI/AER: Remove unused version macros Bjorn Helgaas
2016-11-21 21:45 ` Bjorn Helgaas [this message]
2016-11-21 21:45 ` [PATCH v2 5/9] PCI/AER: Log AER IRQ when claiming Root Port Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 6/9] PCI: Remove service driver load/unload messages Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 7/9] PCI: hotplug: Remove hotplug core message Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 8/9] PCI: pciehp: Remove loading message Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 9/9] PCI: Expand "VPD access disabled" quirk message Bjorn Helgaas
2016-11-23 17:36 ` [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161121214541.21036.3404.stgit@bhelgaas-glaptop.roam.corp.google.com \
    --to=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®