* [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32
@ 2017-02-09 10:18 Carlos Palminha
2017-02-10 17:09 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Carlos Palminha @ 2017-02-09 10:18 UTC (permalink / raw)
To: devel, linux-kernel; +Cc: dan.carpenter, Carlos Palminha, gregkh
Fixed missing conversion to le32, detected by sparse
(invalid assignment from int to __le32)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
v1->v2:
missed sob line (too late in the night...)
drivers/staging/rtl8712/rtl8712_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
index 041508d6ec6d..4231a0a83097 100644
--- a/drivers/staging/rtl8712/rtl8712_xmit.c
+++ b/drivers/staging/rtl8712/rtl8712_xmit.c
@@ -573,7 +573,7 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
}
} else if (pxmitframe->frame_tag == MGNT_FRAMETAG) {
/* offset 4 */
- ptxdesc->txdw1 |= (0x05) & 0x1f;/*CAM_ID(MAC_ID), default=5;*/
+ ptxdesc->txdw1 |= cpu_to_le32((0x05) & 0x1f);/*CAM_ID(MAC_ID), default=5;*/
qsel = (uint)(pattrib->qsel & 0x0000001f);
ptxdesc->txdw1 |= cpu_to_le32((qsel << QSEL_SHT) & 0x00001f00);
ptxdesc->txdw1 |= cpu_to_le32(BIT(16));/* Non-QoS */
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32
2017-02-09 10:18 [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32 Carlos Palminha
@ 2017-02-10 17:09 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-02-10 17:09 UTC (permalink / raw)
To: Carlos Palminha; +Cc: devel, linux-kernel, gregkh
On Thu, Feb 09, 2017 at 10:18:42AM +0000, Carlos Palminha wrote:
> Fixed missing conversion to le32, detected by sparse
> (invalid assignment from int to __le32)
>
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> v1->v2:
> missed sob line (too late in the night...)
>
> drivers/staging/rtl8712/rtl8712_xmit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
> index 041508d6ec6d..4231a0a83097 100644
> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> @@ -573,7 +573,7 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
> }
> } else if (pxmitframe->frame_tag == MGNT_FRAMETAG) {
> /* offset 4 */
> - ptxdesc->txdw1 |= (0x05) & 0x1f;/*CAM_ID(MAC_ID), default=5;*/
> + ptxdesc->txdw1 |= cpu_to_le32((0x05) & 0x1f);/*CAM_ID(MAC_ID), default=5;*/
This looks reasonable but it's probably cleaner to say something like:
ptxdesc->txdw1 |= cpu_to_le32(0x05); /*CAM_ID(MAC_ID), default=5;*/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-10 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 10:18 [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32 Carlos Palminha
2017-02-10 17:09 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®