From: Julia Cartwright <julia@ni.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <linux-kernel@vger.kernel.org>, Jan Kiszka <jan.kiszka@siemens.com>
Subject: [PATCH] trace-cmd: fixup more bogus symbol resolutions
Date: Thu, 16 Feb 2017 16:57:21 -0600 [thread overview]
Message-ID: <20170216225721.13087-1-julia@ni.com> (raw)
Commit ce1cbc51c ("trace-cmd: Leave out absolute addresses to fix bogus
symbol resolutions") fixed up bogus symbol resolution for 'A' type
symbols used on x86_64 for percpu offsets.
However, this check did not cover per-cpu variables used in modules,
which are generated as 'local' absolute symbols, and therefore appear as 'a' in
/proc/kallsyms. Fix this.
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Julia Cartwright <julia@ni.com>
---
trace-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/trace-util.c b/trace-util.c
index 5bf591c..fc5926e 100644
--- a/trace-util.c
+++ b/trace-util.c
@@ -458,7 +458,7 @@ void parse_proc_kallsyms(struct pevent *pevent,
* - arm arch that adds a lot of bogus '$a' functions
* - x86-64 that reports per-cpu variable offsets as absolute
*/
- if (func[0] != '$' && ch != 'A')
+ if (func[0] != '$' && ch != 'A' && ch != 'a')
pevent_register_function(pevent, func, addr, mod);
free(func);
free(mod);
--
2.11.1
reply other threads:[~2017-02-16 22:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216225721.13087-1-julia@ni.com \
--to=julia@ni.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®