mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] trace-cmd: fixup more bogus symbol resolutions
@ 2017-02-16 22:57 Julia Cartwright
  0 siblings, 0 replies; only message in thread
From: Julia Cartwright @ 2017-02-16 22:57 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: linux-kernel, Jan Kiszka

Commit ce1cbc51c ("trace-cmd: Leave out absolute addresses to fix bogus
symbol resolutions") fixed up bogus symbol resolution for 'A' type
symbols used on x86_64 for percpu offsets.

However, this check did not cover per-cpu variables used in modules,
which are generated as 'local' absolute symbols, and therefore appear as 'a' in
/proc/kallsyms.  Fix this.

Cc: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Julia Cartwright <julia@ni.com>
---
 trace-util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trace-util.c b/trace-util.c
index 5bf591c..fc5926e 100644
--- a/trace-util.c
+++ b/trace-util.c
@@ -458,7 +458,7 @@ void parse_proc_kallsyms(struct pevent *pevent,
 		 *  - arm arch that adds a lot of bogus '$a' functions
 		 *  - x86-64 that reports per-cpu variable offsets as absolute
 		 */
-		if (func[0] != '$' && ch != 'A')
+		if (func[0] != '$' && ch != 'A' && ch != 'a')
 			pevent_register_function(pevent, func, addr, mod);
 		free(func);
 		free(mod);
-- 
2.11.1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-02-16 22:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-16 22:57 [PATCH] trace-cmd: fixup more bogus symbol resolutions Julia Cartwright

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®