* [PATCH] IB/qib: fix false-postive maybe-uninitialized warning
@ 2017-02-27 20:43 Arnd Bergmann
2017-02-27 21:22 ` Weiny, Ira
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-02-27 20:43 UTC (permalink / raw)
To: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock
Cc: Arnd Bergmann, Dennis Dalessandro, Ira Weiny, Leon Romanovsky,
Harish Chegondi, Masahiro Yamada, Jubin John, linux-rdma,
linux-kernel
aarch64-linux-gcc-7 complains about code it doesn't fully understand:
drivers/infiniband/hw/qib/qib_iba7322.c: In function 'qib_7322_txchk_change':
include/asm-generic/bitops/non-atomic.h:105:35: error: 'shadow' may be used uninitialized in this function [-Werror=maybe-uninitialized]
The code is right, and despite trying hard, I could not come up with a version
that I liked better than just adding a fake initialization here to shut up the
warning.
Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b/drivers/infiniband/hw/qib/qib_iba7322.c
index 12c4208fd701..af9f596bb68b 100644
--- a/drivers/infiniband/hw/qib/qib_iba7322.c
+++ b/drivers/infiniband/hw/qib/qib_iba7322.c
@@ -7068,7 +7068,7 @@ static void qib_7322_txchk_change(struct qib_devdata *dd, u32 start,
unsigned long flags;
while (wait) {
- unsigned long shadow;
+ unsigned long shadow = 0;
int cstart, previ = -1;
/*
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [PATCH] IB/qib: fix false-postive maybe-uninitialized warning
2017-02-27 20:43 [PATCH] IB/qib: fix false-postive maybe-uninitialized warning Arnd Bergmann
@ 2017-02-27 21:22 ` Weiny, Ira
0 siblings, 0 replies; 2+ messages in thread
From: Weiny, Ira @ 2017-02-27 21:22 UTC (permalink / raw)
To: Arnd Bergmann, infinipath, Doug Ledford, Hefty, Sean, Hal Rosenstock
Cc: Dalessandro, Dennis, Leon Romanovsky, Chegondi, Harish,
Masahiro Yamada, John, Jubin, linux-rdma, linux-kernel
>
> aarch64-linux-gcc-7 complains about code it doesn't fully understand:
>
> drivers/infiniband/hw/qib/qib_iba7322.c: In function
> 'qib_7322_txchk_change':
> include/asm-generic/bitops/non-atomic.h:105:35: error: 'shadow' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
>
> The code is right, and despite trying hard, I could not come up with a version
> that I liked better than just adding a fake initialization here to shut up the
> warning.
>
> Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand
> adapters")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Sounds reasonable to me.
Acked-by: Ira Weiny <ira.weiny@intel.com>
> drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c
> b/drivers/infiniband/hw/qib/qib_iba7322.c
> index 12c4208fd701..af9f596bb68b 100644
> --- a/drivers/infiniband/hw/qib/qib_iba7322.c
> +++ b/drivers/infiniband/hw/qib/qib_iba7322.c
> @@ -7068,7 +7068,7 @@ static void qib_7322_txchk_change(struct
> qib_devdata *dd, u32 start,
> unsigned long flags;
>
> while (wait) {
> - unsigned long shadow;
> + unsigned long shadow = 0;
> int cstart, previ = -1;
>
> /*
> --
> 2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-28 5:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-27 20:43 [PATCH] IB/qib: fix false-postive maybe-uninitialized warning Arnd Bergmann
2017-02-27 21:22 ` Weiny, Ira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®