mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
	linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Gregor Boirie <gregor.boirie@parrot.com>,
	Sanchayan Maity <maitysanchayan@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Alison Schofield <amsfield22@gmail.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: [PATCH v2 09/17] iio: accel: bma180: Add OF device ID table
Date: Wed, 15 Mar 2017 01:44:57 -0300	[thread overview]
Message-ID: <20170315044505.20660-10-javier@osg.samsung.com> (raw)
In-Reply-To: <20170315044505.20660-1-javier@osg.samsung.com>

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/iio/accel/bma180.c | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index 0890934ef66f..e3f97757e72d 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -18,6 +18,7 @@
 #include <linux/i2c.h>
 #include <linux/interrupt.h>
 #include <linux/delay.h>
+#include <linux/of_device.h>
 #include <linux/of.h>
 #include <linux/bitops.h>
 #include <linux/slab.h>
@@ -32,7 +33,7 @@
 #define BMA180_DRV_NAME "bma180"
 #define BMA180_IRQ_NAME "bma180_event"
 
-enum {
+enum chip_ids {
 	BMA180,
 	BMA250,
 };
@@ -707,6 +708,7 @@ static int bma180_probe(struct i2c_client *client,
 {
 	struct bma180_data *data;
 	struct iio_dev *indio_dev;
+	enum chip_ids chip;
 	int ret;
 
 	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
@@ -716,7 +718,11 @@ static int bma180_probe(struct i2c_client *client,
 	data = iio_priv(indio_dev);
 	i2c_set_clientdata(client, indio_dev);
 	data->client = client;
-	data->part_info = &bma180_part_info[id->driver_data];
+	if (client->dev.of_node)
+		chip = (enum chip_ids)of_device_get_match_data(&client->dev);
+	else
+		chip = id->driver_data;
+	data->part_info = &bma180_part_info[chip];
 
 	ret = data->part_info->chip_config(data);
 	if (ret < 0)
@@ -844,10 +850,24 @@ static struct i2c_device_id bma180_ids[] = {
 
 MODULE_DEVICE_TABLE(i2c, bma180_ids);
 
+static const struct of_device_id bma180_of_match[] = {
+	{
+		.compatible = "bosch,bma180",
+		.data = (void *)BMA180
+	},
+	{
+		.compatible = "bosch,bma250",
+		.data = (void *)BMA250
+	},
+	{ }
+};
+MODULE_DEVICE_TABLE(of, bma180_of_match);
+
 static struct i2c_driver bma180_driver = {
 	.driver = {
 		.name	= "bma180",
 		.pm	= BMA180_PM_OPS,
+		.of_match_table = bma180_of_match,
 	},
 	.probe		= bma180_probe,
 	.remove		= bma180_remove,
-- 
2.9.3

  parent reply	other threads:[~2017-03-15  4:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15  4:44 [PATCH v2 00/17] iio: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-03-15  4:44 ` [PATCH v2 01/17] iio: adc: ina2xx: Add OF device ID table Javier Martinez Canillas
2017-03-19 10:48   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 02/17] iio: mlx96014: " Javier Martinez Canillas
2017-03-15 10:46   ` Crt Mori
2017-03-19 10:49     ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 03/17] iio: magnetometer: bmc150_magn_i2c: " Javier Martinez Canillas
2017-03-19 10:50   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 04/17] iio: dac: mcp4725: " Javier Martinez Canillas
2017-03-19 10:51   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 05/17] iio: light: us5182d: " Javier Martinez Canillas
2017-03-19 10:52   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 06/17] iio: light: tsl2563: " Javier Martinez Canillas
2017-03-19 10:53   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 07/17] iio: pressure: hp03: " Javier Martinez Canillas
2017-03-19 10:53   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 08/17] iio: imu: inv_mpu6050: " Javier Martinez Canillas
2017-03-19 10:54   ` Jonathan Cameron
2017-03-15  4:44 ` Javier Martinez Canillas [this message]
2017-03-19 10:55   ` [PATCH v2 09/17] iio: accel: bma180: " Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 10/17] iio: light: apds9960: " Javier Martinez Canillas
2017-03-19 10:55   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 11/17] iio: dac: max5821: Set .of_match_table to " Javier Martinez Canillas
2017-03-19 10:56   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 12/17] iio: adc: ti-ads1015: Add " Javier Martinez Canillas
2017-03-19 10:57   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 13/17] iio: magnetometer: mag3110: " Javier Martinez Canillas
2017-03-19 10:57   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 14/17] iio: accel: mma7455_i2c: " Javier Martinez Canillas
2017-03-19 10:57   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 15/17] iio: pressure: mpl3115: " Javier Martinez Canillas
2017-03-19 10:58   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 16/17] iio: accel: mma7660: " Javier Martinez Canillas
2017-03-19 10:58   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 17/17] iio: gyro: itg3200: " Javier Martinez Canillas
2017-03-19 10:59   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170315044505.20660-10-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=amsfield22@gmail.com \
    --cc=gregor.boirie@parrot.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maitysanchayan@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®