mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
	Matt Ranostay <mranostay@gmail.com>,
	linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Gregor Boirie <gregor.boirie@parrot.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Alison Schofield <amsfield22@gmail.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Marc Titinger <mtitinger@baylibre.com>
Subject: [PATCH v2 01/17] iio: adc: ina2xx: Add OF device ID table
Date: Wed, 15 Mar 2017 01:44:49 -0300	[thread overview]
Message-ID: <20170315044505.20660-2-javier@osg.samsung.com> (raw)
In-Reply-To: <20170315044505.20660-1-javier@osg.samsung.com>

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/iio/adc/ina2xx-adc.c | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
index 3263231276ca..db9838230257 100644
--- a/drivers/iio/adc/ina2xx-adc.c
+++ b/drivers/iio/adc/ina2xx-adc.c
@@ -28,6 +28,7 @@
 #include <linux/iio/sysfs.h>
 #include <linux/kthread.h>
 #include <linux/module.h>
+#include <linux/of_device.h>
 #include <linux/regmap.h>
 #include <linux/util_macros.h>
 
@@ -635,6 +636,7 @@ static int ina2xx_probe(struct i2c_client *client,
 	struct iio_dev *indio_dev;
 	struct iio_buffer *buffer;
 	unsigned int val;
+	enum ina2xx_ids type;
 	int ret;
 
 	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*chip));
@@ -652,7 +654,11 @@ static int ina2xx_probe(struct i2c_client *client,
 		return PTR_ERR(chip->regmap);
 	}
 
-	chip->config = &ina2xx_config[id->driver_data];
+	if (client->dev.of_node)
+		type = (enum ina2xx_ids)of_device_get_match_data(&client->dev);
+	else
+		type = id->driver_data;
+	chip->config = &ina2xx_config[type];
 
 	mutex_init(&chip->state_lock);
 
@@ -726,9 +732,35 @@ static const struct i2c_device_id ina2xx_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, ina2xx_id);
 
+static const struct of_device_id ina2xx_of_match[] = {
+	{
+		.compatible = "ti,ina219",
+		.data = (void *)ina219
+	},
+	{
+		.compatible = "ti,ina220",
+		.data = (void *)ina219
+	},
+	{
+		.compatible = "ti,ina226",
+		.data = (void *)ina226
+	},
+	{
+		.compatible = "ti,ina230",
+		.data = (void *)ina226
+	},
+	{
+		.compatible = "ti,ina231",
+		.data = (void *)ina226
+	},
+	{},
+};
+MODULE_DEVICE_TABLE(of, ina2xx_of_match);
+
 static struct i2c_driver ina2xx_driver = {
 	.driver = {
 		   .name = KBUILD_MODNAME,
+		   .of_match_table = ina2xx_of_match,
 	},
 	.probe = ina2xx_probe,
 	.remove = ina2xx_remove,
-- 
2.9.3

  reply	other threads:[~2017-03-15  4:45 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15  4:44 [PATCH v2 00/17] iio: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-03-15  4:44 ` Javier Martinez Canillas [this message]
2017-03-19 10:48   ` [PATCH v2 01/17] iio: adc: ina2xx: Add OF device ID table Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 02/17] iio: mlx96014: " Javier Martinez Canillas
2017-03-15 10:46   ` Crt Mori
2017-03-19 10:49     ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 03/17] iio: magnetometer: bmc150_magn_i2c: " Javier Martinez Canillas
2017-03-19 10:50   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 04/17] iio: dac: mcp4725: " Javier Martinez Canillas
2017-03-19 10:51   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 05/17] iio: light: us5182d: " Javier Martinez Canillas
2017-03-19 10:52   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 06/17] iio: light: tsl2563: " Javier Martinez Canillas
2017-03-19 10:53   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 07/17] iio: pressure: hp03: " Javier Martinez Canillas
2017-03-19 10:53   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 08/17] iio: imu: inv_mpu6050: " Javier Martinez Canillas
2017-03-19 10:54   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 09/17] iio: accel: bma180: " Javier Martinez Canillas
2017-03-19 10:55   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 10/17] iio: light: apds9960: " Javier Martinez Canillas
2017-03-19 10:55   ` Jonathan Cameron
2017-03-15  4:44 ` [PATCH v2 11/17] iio: dac: max5821: Set .of_match_table to " Javier Martinez Canillas
2017-03-19 10:56   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 12/17] iio: adc: ti-ads1015: Add " Javier Martinez Canillas
2017-03-19 10:57   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 13/17] iio: magnetometer: mag3110: " Javier Martinez Canillas
2017-03-19 10:57   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 14/17] iio: accel: mma7455_i2c: " Javier Martinez Canillas
2017-03-19 10:57   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 15/17] iio: pressure: mpl3115: " Javier Martinez Canillas
2017-03-19 10:58   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 16/17] iio: accel: mma7660: " Javier Martinez Canillas
2017-03-19 10:58   ` Jonathan Cameron
2017-03-15  4:45 ` [PATCH v2 17/17] iio: gyro: itg3200: " Javier Martinez Canillas
2017-03-19 10:59   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170315044505.20660-2-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=amsfield22@gmail.com \
    --cc=gregor.boirie@parrot.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mranostay@gmail.com \
    --cc=mtitinger@baylibre.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®