Re: [PATCH] mmc: sunxi: change controller error info to debug level

Re: [PATCH] mmc: sunxi: change controller error info to debug level

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

On Thu, Mar 16, 2017 at 09:29:03PM +0800, Icenowy Zheng wrote:
> The controller's errors are usually normal (for example, for MMC or SDIO
> cards, some errors are expected to happen; and for boards without a
> dedicated card detect pin the error info will even flood console and
> hide other normal messages) and hard to understand.
> 
> Change their print level to debug, thus it won't be shown to generic
> users.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH] mmc: sunxi: change controller error info to debug level

[Ulf Hansson]

On 16 March 2017 at 14:29, Icenowy Zheng <icenowy@aosc.xyz> wrote:
> The controller's errors are usually normal (for example, for MMC or SDIO
> cards, some errors are expected to happen; and for boards without a
> dedicated card detect pin the error info will even flood console and
> hide other normal messages) and hard to understand.
>
> Change their print level to debug, thus it won't be shown to generic
> users.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

For some reason this change didn't enter the mmc patchtracker. However
I have picked it up for next anyway.

Thanks!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sunxi-mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index 6ffcd2838272..0391c62cc99f 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -489,7 +489,7 @@ static void sunxi_mmc_dump_errinfo(struct sunxi_mmc_host *host)
>                                       cmd->opcode == SD_IO_RW_DIRECT))
>                 return;
>
> -       dev_err(mmc_dev(host->mmc),
> +       dev_dbg(mmc_dev(host->mmc),
>                 "smc %d err, cmd %d,%s%s%s%s%s%s%s%s%s%s !!\n",
>                 host->mmc->index, cmd->opcode,
>                 data ? (data->flags & MMC_DATA_WRITE ? " WR" : " RD") : "",
> --
> 2.12.0
>