* Re: [PATCH] mmc: sunxi: change controller error info to debug level
[not found] <20170316132903.61246-1-icenowy@aosc.xyz>
@ 2017-03-20 8:59 ` Maxime Ripard
2017-03-24 7:46 ` Ulf Hansson
1 sibling, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2017-03-20 8:59 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Ulf Hansson, Chen-Yu Tsai, Hans de Goede, linux-mmc,
linux-arm-kernel, linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On Thu, Mar 16, 2017 at 09:29:03PM +0800, Icenowy Zheng wrote:
> The controller's errors are usually normal (for example, for MMC or SDIO
> cards, some errors are expected to happen; and for boards without a
> dedicated card detect pin the error info will even flood console and
> hide other normal messages) and hard to understand.
>
> Change their print level to debug, thus it won't be shown to generic
> users.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: sunxi: change controller error info to debug level
[not found] <20170316132903.61246-1-icenowy@aosc.xyz>
2017-03-20 8:59 ` [PATCH] mmc: sunxi: change controller error info to debug level Maxime Ripard
@ 2017-03-24 7:46 ` Ulf Hansson
1 sibling, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2017-03-24 7:46 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Maxime Ripard, Chen-Yu Tsai, Hans de Goede, linux-mmc,
linux-arm-kernel, linux-kernel, linux-sunxi
On 16 March 2017 at 14:29, Icenowy Zheng <icenowy@aosc.xyz> wrote:
> The controller's errors are usually normal (for example, for MMC or SDIO
> cards, some errors are expected to happen; and for boards without a
> dedicated card detect pin the error info will even flood console and
> hide other normal messages) and hard to understand.
>
> Change their print level to debug, thus it won't be shown to generic
> users.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
For some reason this change didn't enter the mmc patchtracker. However
I have picked it up for next anyway.
Thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sunxi-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index 6ffcd2838272..0391c62cc99f 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -489,7 +489,7 @@ static void sunxi_mmc_dump_errinfo(struct sunxi_mmc_host *host)
> cmd->opcode == SD_IO_RW_DIRECT))
> return;
>
> - dev_err(mmc_dev(host->mmc),
> + dev_dbg(mmc_dev(host->mmc),
> "smc %d err, cmd %d,%s%s%s%s%s%s%s%s%s%s !!\n",
> host->mmc->index, cmd->opcode,
> data ? (data->flags & MMC_DATA_WRITE ? " WR" : " RD") : "",
> --
> 2.12.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread