From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Vincent Guittot <vincent.guittot@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Juri Lelli <juri.lelli@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>
Subject: [RFC PATCH 5/5] sched/events: Introduce task_group load tracking trace event
Date: Tue, 28 Mar 2017 07:35:41 +0100 [thread overview]
Message-ID: <20170328063541.12912-6-dietmar.eggemann@arm.com> (raw)
In-Reply-To: <20170328063541.12912-1-dietmar.eggemann@arm.com>
The trace event key load is mapped to:
(1) load : cfs_rq->tg->load_avg
The cfs_rq owned by the task_group is used as the only parameter for the
trace event because it has a reference to the taskgroup and the cpu.
Using the taskgroup as a parameter instead would require the cpu as a
second parameter. A task_group is global and not per-cpu data. The cpu
key only tells on which cpu the value was gathered.
The following list shows examples of the key=value pairs for:
(1) a task group:
cpu=1 path=/tg1/tg11/tg111 id=4 load=517
(2) an autogroup:
cpu=1 path=/autogroup-10 id=0 load=1050
We don't maintain a load signal for a root task group.
The trace event is only defined if cfs group scheduling support
(CONFIG_FAIR_GROUP_SCHED) is enabled.
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
---
include/trace/events/sched.h | 31 +++++++++++++++++++++++++++++++
kernel/sched/fair.c | 2 ++
2 files changed, 33 insertions(+)
diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index 647cfaf528fd..3fe0092176f8 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -673,6 +673,37 @@ TRACE_EVENT(sched_load_se,
__entry->cpu, __get_str(path), __entry->id, __entry->comm,
__entry->pid, __entry->load, __entry->util)
);
+
+/*
+ * Tracepoint for task_group load tracking:
+ */
+#ifdef CONFIG_FAIR_GROUP_SCHED
+TRACE_EVENT(sched_load_tg,
+
+ TP_PROTO(struct cfs_rq *cfs_rq),
+
+ TP_ARGS(cfs_rq),
+
+ TP_STRUCT__entry(
+ __field( int, cpu )
+ __dynamic_array(char, path,
+ __trace_sched_path(cfs_rq, NULL, 0) )
+ __field( int, id )
+ __field( long, load )
+ ),
+
+ TP_fast_assign(
+ __entry->cpu = cfs_rq->rq->cpu;
+ __trace_sched_path(cfs_rq, __get_dynamic_array(path),
+ __get_dynamic_array_len(path));
+ __entry->id = cfs_rq->tg->css.id;
+ __entry->load = atomic_long_read(&cfs_rq->tg->load_avg);
+ ),
+
+ TP_printk("cpu=%d path=%s id=%d load=%ld", __entry->cpu,
+ __get_str(path), __entry->id, __entry->load)
+);
+#endif /* CONFIG_FAIR_GROUP_SCHED */
#endif /* CONFIG_SMP */
#endif /* _TRACE_SCHED_H */
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d1dcb19f5b55..dbe2d5ef8b9e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2997,6 +2997,8 @@ static inline void update_tg_load_avg(struct cfs_rq *cfs_rq, int force)
atomic_long_add(delta, &cfs_rq->tg->load_avg);
cfs_rq->tg_load_avg_contrib = cfs_rq->avg.load_avg;
}
+
+ trace_sched_load_tg(cfs_rq);
}
/*
--
2.11.0
next prev parent reply other threads:[~2017-03-28 6:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 6:35 [RFC PATCH 0/5] CFS load tracking trace events Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 1/5] sched/autogroup: Define autogroup_path() for !CONFIG_SCHED_DEBUG Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking trace event Dietmar Eggemann
2017-03-28 7:56 ` Peter Zijlstra
2017-03-28 13:30 ` Dietmar Eggemann
2017-03-28 8:00 ` Peter Zijlstra
2017-03-28 14:47 ` Steven Rostedt
2017-03-28 14:46 ` Steven Rostedt
2017-03-28 16:44 ` Peter Zijlstra
2017-03-28 16:57 ` Peter Zijlstra
2017-03-28 17:20 ` Patrick Bellasi
2017-03-28 18:18 ` Peter Zijlstra
2017-03-28 17:36 ` Steven Rostedt
2017-03-28 17:37 ` Steven Rostedt
2017-03-29 20:37 ` Dietmar Eggemann
2017-03-29 21:03 ` Dietmar Eggemann
2017-03-30 7:04 ` Peter Zijlstra
2017-03-30 7:46 ` Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 3/5] sched/fair: Export group_cfs_rq() Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 4/5] sched/events: Introduce sched_entity load tracking trace event Dietmar Eggemann
2017-03-28 8:05 ` Peter Zijlstra
2017-03-28 14:01 ` Dietmar Eggemann
2017-03-28 14:03 ` Dietmar Eggemann
2017-03-28 8:08 ` Peter Zijlstra
2017-03-28 14:13 ` Dietmar Eggemann
2017-03-28 16:41 ` Peter Zijlstra
2017-03-29 20:19 ` Dietmar Eggemann
2017-03-28 6:35 ` Dietmar Eggemann [this message]
2017-03-28 10:05 ` [RFC PATCH 0/5] CFS load tracking trace events Vincent Guittot
2017-03-28 13:45 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328063541.12912-6-dietmar.eggemann@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®