From: Peter Zijlstra <peterz@infradead.org>
To: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Juri Lelli <juri.lelli@arm.com>
Subject: Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking trace event
Date: Tue, 28 Mar 2017 20:18:15 +0200 [thread overview]
Message-ID: <20170328181815.m243aymvimyidiq2@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170328172005.GF11362@e110439-lin>
On Tue, Mar 28, 2017 at 06:20:05PM +0100, Patrick Bellasi wrote:
> On 28-Mar 18:57, Peter Zijlstra wrote:
> > On Tue, Mar 28, 2017 at 06:44:59PM +0200, Peter Zijlstra wrote:
> > > +static int
> > > +__update_load_avg(u64 now, int cpu, struct sched_avg *sa,
> > > + unsigned long weight, int running, struct cfs_rq *cfs_rq)
>
> __attribute__((nonnull (6)));
>
> > > +{
> > > + return ___update_load_avg(now, cpu, sa, weight, running, cfs_rq);
> >
> > Although ideally we'd be able to tell the compiler that cfs_rq will not
> > be NULL here. Hurmph.. no __builtin for that I think :/
>
> What about the above attribute?
Ooh, shiny, thanks! My bad for failing to check the function attributes.
next prev parent reply other threads:[~2017-03-28 18:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 6:35 [RFC PATCH 0/5] CFS load tracking trace events Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 1/5] sched/autogroup: Define autogroup_path() for !CONFIG_SCHED_DEBUG Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking trace event Dietmar Eggemann
2017-03-28 7:56 ` Peter Zijlstra
2017-03-28 13:30 ` Dietmar Eggemann
2017-03-28 8:00 ` Peter Zijlstra
2017-03-28 14:47 ` Steven Rostedt
2017-03-28 14:46 ` Steven Rostedt
2017-03-28 16:44 ` Peter Zijlstra
2017-03-28 16:57 ` Peter Zijlstra
2017-03-28 17:20 ` Patrick Bellasi
2017-03-28 18:18 ` Peter Zijlstra [this message]
2017-03-28 17:36 ` Steven Rostedt
2017-03-28 17:37 ` Steven Rostedt
2017-03-29 20:37 ` Dietmar Eggemann
2017-03-29 21:03 ` Dietmar Eggemann
2017-03-30 7:04 ` Peter Zijlstra
2017-03-30 7:46 ` Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 3/5] sched/fair: Export group_cfs_rq() Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 4/5] sched/events: Introduce sched_entity load tracking trace event Dietmar Eggemann
2017-03-28 8:05 ` Peter Zijlstra
2017-03-28 14:01 ` Dietmar Eggemann
2017-03-28 14:03 ` Dietmar Eggemann
2017-03-28 8:08 ` Peter Zijlstra
2017-03-28 14:13 ` Dietmar Eggemann
2017-03-28 16:41 ` Peter Zijlstra
2017-03-29 20:19 ` Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 5/5] sched/events: Introduce task_group " Dietmar Eggemann
2017-03-28 10:05 ` [RFC PATCH 0/5] CFS load tracking trace events Vincent Guittot
2017-03-28 13:45 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328181815.m243aymvimyidiq2@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome