From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Steven Rostedt <rostedt@goodmis.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Juri Lelli <juri.lelli@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>
Subject: Re: [RFC PATCH 0/5] CFS load tracking trace events
Date: Tue, 28 Mar 2017 15:45:59 +0200 [thread overview]
Message-ID: <550d2e4e-96c0-11de-f674-ea0fea870948@arm.com> (raw)
In-Reply-To: <CAKfTPtByOR1r8ATJrYnF=YeJDh+d4fKgZsntWwgS7PonjZsw0g@mail.gmail.com>
On 03/28/2017 12:05 PM, Vincent Guittot wrote:
> On 28 March 2017 at 08:35, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
[...]
>> The following keys are used to identify the cfs scheduler brick:
>>
>> (1) Cpu number the cfs scheduler brick is attached to.
>>
>> (2) Task_group path and (css) id.
>>
>> (3) Task name and pid.
>
> Do you really need both path/name and id/pid ?
>
> The path/name looks quite intrusive so can't we just use id/pid ?
One problem is that all autogroups use id=0.
Another thing with task_groups is that dealing with path="/tg1/tg11" is
so much more intuitive than id="7".
IMHO, we do need task name and pid to be able to clearly identify a task
(same name/different pid or fork phase (forkee still has name of forker)).
You're right, the implementation with path is more complicated but I
guess that's worth it. We could get rid of 'id' though.
[...]
prev parent reply other threads:[~2017-03-28 13:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 6:35 Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 1/5] sched/autogroup: Define autogroup_path() for !CONFIG_SCHED_DEBUG Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking trace event Dietmar Eggemann
2017-03-28 7:56 ` Peter Zijlstra
2017-03-28 13:30 ` Dietmar Eggemann
2017-03-28 8:00 ` Peter Zijlstra
2017-03-28 14:47 ` Steven Rostedt
2017-03-28 14:46 ` Steven Rostedt
2017-03-28 16:44 ` Peter Zijlstra
2017-03-28 16:57 ` Peter Zijlstra
2017-03-28 17:20 ` Patrick Bellasi
2017-03-28 18:18 ` Peter Zijlstra
2017-03-28 17:36 ` Steven Rostedt
2017-03-28 17:37 ` Steven Rostedt
2017-03-29 20:37 ` Dietmar Eggemann
2017-03-29 21:03 ` Dietmar Eggemann
2017-03-30 7:04 ` Peter Zijlstra
2017-03-30 7:46 ` Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 3/5] sched/fair: Export group_cfs_rq() Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 4/5] sched/events: Introduce sched_entity load tracking trace event Dietmar Eggemann
2017-03-28 8:05 ` Peter Zijlstra
2017-03-28 14:01 ` Dietmar Eggemann
2017-03-28 14:03 ` Dietmar Eggemann
2017-03-28 8:08 ` Peter Zijlstra
2017-03-28 14:13 ` Dietmar Eggemann
2017-03-28 16:41 ` Peter Zijlstra
2017-03-29 20:19 ` Dietmar Eggemann
2017-03-28 6:35 ` [RFC PATCH 5/5] sched/events: Introduce task_group " Dietmar Eggemann
2017-03-28 10:05 ` [RFC PATCH 0/5] CFS load tracking trace events Vincent Guittot
2017-03-28 13:45 ` Dietmar Eggemann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550d2e4e-96c0-11de-f674-ea0fea870948@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®