From: Hans de Goede <hdegoede@redhat.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: Hans de Goede <hdegoede@redhat.com>, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] extcon: intel-cht-wc: Make error messages consistent
Date: Mon, 3 Apr 2017 13:26:28 +0200 [thread overview]
Message-ID: <20170403112630.30625-1-hdegoede@redhat.com> (raw)
Before this commit the error messages were a mix of "Failed to ..." and
"Error ...ing ...".
This commit makes all the error messages consistently use "Error ...ing".
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/extcon/extcon-intel-cht-wc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/extcon/extcon-intel-cht-wc.c b/drivers/extcon/extcon-intel-cht-wc.c
index 0a05cc3..f1c43af 100644
--- a/drivers/extcon/extcon-intel-cht-wc.c
+++ b/drivers/extcon/extcon-intel-cht-wc.c
@@ -252,7 +252,7 @@ static int cht_wc_extcon_sw_control(struct cht_wc_extcon_data *ext, bool enable)
val = enable ? mask : 0;
ret = regmap_update_bits(ext->regmap, CHT_WC_CHGRCTRL0, mask, val);
if (ret)
- dev_err(ext->dev, "Failed setting sw control: %d\n", ret);
+ dev_err(ext->dev, "Error setting sw control: %d\n", ret);
return ret;
}
@@ -288,7 +288,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev)
/* Register extcon device */
ret = devm_extcon_dev_register(ext->dev, ext->edev);
if (ret) {
- dev_err(ext->dev, "Failed to register extcon device\n");
+ dev_err(ext->dev, "Error registering extcon device: %d\n", ret);
goto disable_sw_control;
}
@@ -301,7 +301,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(ext->dev, irq, NULL, cht_wc_extcon_isr,
IRQF_ONESHOT, pdev->name, ext);
if (ret) {
- dev_err(ext->dev, "Failed to request interrupt\n");
+ dev_err(ext->dev, "Error requesting interrupt: %d\n", ret);
goto disable_sw_control;
}
@@ -310,7 +310,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev)
(int)~(CHT_WC_PWRSRC_VBUS | CHT_WC_PWRSRC_ID_GND |
CHT_WC_PWRSRC_ID_FLOAT));
if (ret) {
- dev_err(ext->dev, "Failed to write the irq-mask: %d\n", ret);
+ dev_err(ext->dev, "Error writing irq-mask: %d\n", ret);
goto disable_sw_control;
}
--
2.9.3
next reply other threads:[~2017-04-03 11:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170403112709epcas3p331d80584db95bebe4d0ce2a020ffdbf0@epcas3p3.samsung.com>
2017-04-03 11:26 ` Hans de Goede [this message]
2017-04-03 11:26 ` [PATCH 2/3] extcon: intel-cht-wc: Disable external 5v boost converter on probe Hans de Goede
2017-04-04 6:31 ` Chanwoo Choi
2017-04-04 10:52 ` Hans de Goede
2017-04-03 11:26 ` [PATCH 3/3] extcon: intel-cht-wc: Ignore failure to detect charger-type on host mode exit Hans de Goede
2017-04-04 6:19 ` [PATCH 1/3] extcon: intel-cht-wc: Make error messages consistent Chanwoo Choi
2017-04-04 8:53 ` Hans de Goede
2017-04-04 11:58 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403112630.30625-1-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®