[PATCH] Make ANDROID a menuconfig to ease disabling it all

[PATCH] Make ANDROID a menuconfig to ease disabling it all

[Vincent Legoll]

No need to get into the submenu to disable all ANDROID-related config entries

Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
 drivers/android/Kconfig | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
index a82fc02..c2b6c37 100644
--- a/drivers/android/Kconfig
+++ b/drivers/android/Kconfig
@@ -1,15 +1,11 @@
-menu "Android"
-
-config ANDROID
+menuconfig ANDROID
 	bool "Android Drivers"
 	---help---
 	  Enable support for various drivers needed on the Android platform
 
-if ANDROID
-
 config ANDROID_BINDER_IPC
 	bool "Android Binder IPC Driver"
-	depends on MMU
+	depends on ANDROID && MMU
 	default n
 	---help---
 	  Binder is used in Android for both communication between processes,
@@ -43,7 +39,3 @@ config ANDROID_BINDER_IPC_32BIT
 	  earlier).
 
 	  Note that enabling this will break newer Android user-space.
-
-endif # if ANDROID
-
-endmenu
-- 
2.9.3

Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

[Greg KH]

On Fri, Apr 14, 2017 at 11:04:21AM +0200, Vincent Legoll wrote:
> No need to get into the submenu to disable all ANDROID-related config entries

I don't understand this, what exactly do you mean?

> 
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
>  drivers/android/Kconfig | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
> index a82fc02..c2b6c37 100644
> --- a/drivers/android/Kconfig
> +++ b/drivers/android/Kconfig
> @@ -1,15 +1,11 @@
> -menu "Android"
> -
> -config ANDROID
> +menuconfig ANDROID
>  	bool "Android Drivers"
>  	---help---
>  	  Enable support for various drivers needed on the Android platform
>  
> -if ANDROID
> -
>  config ANDROID_BINDER_IPC
>  	bool "Android Binder IPC Driver"
> -	depends on MMU
> +	depends on ANDROID && MMU
>  	default n
>  	---help---
>  	  Binder is used in Android for both communication between processes,
> @@ -43,7 +39,3 @@ config ANDROID_BINDER_IPC_32BIT
>  	  earlier).
>  
>  	  Note that enabling this will break newer Android user-space.
> -
> -endif # if ANDROID
> -
> -endmenu

There are other ANDROID config options in the kernel other than right
here, so having a "menu" is a bit odd, right?

thanks,

greg k-h

Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

[Vincent Legoll]

Hello,

>> No need to get into the submenu to disable all ANDROID-related config entries
>
> I don't understand this, what exactly do you mean?

This is intended for people using make menuconfig to tailor
their kernel config to their need by disabling all options they
don't need. In order to have a smaller kernel, for example,
but also to get smaller build times.

So what this patch (and the others I also sent) is doing:

There was a "menu", under which you have some config entries.
In order to disable any or all of those config entries, you have
to enter the submenu to then select each one and disable it.

With a menuentry (and config options depending on it), you get
a way to disable all those config entries at once without having
to enter the menu.

Does that make sense ?
Is there a better way to achieve the disabling-easiness goal ?

Any input appreciated.

Thanks

-- 
Vincent Legoll

Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

[Greg KH]

On Fri, Apr 14, 2017 at 11:46:07AM +0200, Vincent Legoll wrote:
> Hello,
> 
> >> No need to get into the submenu to disable all ANDROID-related config entries
> >
> > I don't understand this, what exactly do you mean?
> 
> This is intended for people using make menuconfig to tailor
> their kernel config to their need by disabling all options they
> don't need. In order to have a smaller kernel, for example,
> but also to get smaller build times.

That's fine, but you aren't actually changing the functionality of any
of the build options here.  You are just adding a 'menu' and showing
things a bit differently.  You aren't changing any dependancies (which
is what dictates what is and is not built), which does not make it
easier, or harder, to disable/enable anything here.

I'm not against this, but you need to explain it a lot better as to what
you are doing and why.  The "why" isn't covered by the "this will make
the kernel build smaller", as that's just not true :)

thanks,

greg k-h

Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

[Vincent Legoll]

On Fri, Apr 14, 2017 at 2:32 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> That's fine, but you aren't actually changing the functionality of any
> of the build options here.  You are just adding a 'menu' and showing
> things a bit differently.

Yes exactly, I did not intend to change functionality, only ease disabling
options, by not having to enter the menu. I.e. nothing much, especially
for this one where the new now-unconfigurable menu will only have a
single config entry inside (in fact I assumed there would be more coming)

That's why I let it stay inside a menu, and not straight removing the menu
and moved the config option one level up...

>  You aren't changing any dependancies (which
> is what dictates what is and is not built), which does not make it
> easier, or harder, to disable/enable anything here.

I think I don't understand what you're telling here, I added a dep to ANDROID
for the  ANDROID_BINDER_IPC config entry.

> I'm not against this, but you need to explain it a lot better as to what
> you are doing and why.  The "why" isn't covered by the "this will make
> the kernel build smaller", as that's just not true :)

This is not intended to make the kernel build smaller, but to ease the tedious
process of going through "make menuconfig" and disabling all the options you
don't need.

The quantity of options has greatly increased, and when I could do a minimal
kernel config in a few minutes years ago, I now have to take tens of minutes
going through all. This work is a step trying to make this step quicker.

Is that better ?

Thanks

-- 
Vincent Legoll

[PATCH] Make ANDROID a menuconfig to ease disabling it all

[Vincent Legoll]

No need to get into the submenu to disable all ANDROID-related config entries

Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
 drivers/android/Kconfig | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
index 7dce3795b887..e9434777acba 100644
--- a/drivers/android/Kconfig
+++ b/drivers/android/Kconfig
@@ -1,7 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
-menu "Android"
-
-config ANDROID
+menuconfig ANDROID
 	bool "Android Drivers"
 	---help---
 	  Enable support for various drivers needed on the Android platform
@@ -56,5 +54,3 @@ config ANDROID_BINDER_IPC_SELFTEST
 	  alignments.
 
 endif # if ANDROID
-
-endmenu
-- 
2.11.0