From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Lynn Lei <lynnl.jr@outlook.com>
Cc: "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"teddy.wang@siliconmotion.com" <teddy.wang@siliconmotion.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement
Date: Fri, 28 Apr 2017 12:33:47 +0200 [thread overview]
Message-ID: <20170428103347.GA7868@kroah.com> (raw)
In-Reply-To: <CO2PR07MB633E8089233A3B02B79D979931E0@CO2PR07MB633.namprd07.prod.outlook.com>
On Tue, Apr 25, 2017 at 03:53:02PM +0000, Lynn Lei wrote:
> Combine two separate set GPIO(30 & 31) operations into one statement.
Why?
>
> Signed-off-by: Lynn Lei <lynnl.jr@outlook.com>
> ---
> drivers/staging/sm750fb/ddk750_hwi2c.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
> index 68716ef7cb06..ddb7a6dc265a 100644
> --- a/drivers/staging/sm750fb/ddk750_hwi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c
> @@ -49,8 +49,7 @@ void sm750_hw_i2c_close(void)
>
> /* Set GPIO 30 & 31 back as GPIO pins */
> value = peek32(GPIO_MUX);
> - value &= ~GPIO_MUX_30;
> - value &= ~GPIO_MUX_31;
> + value &= ~(GPIO_MUX_30 | GPIO_MUX_31);
Why does this matter?
thanks,
greg k-h
parent reply other threads:[~2017-04-28 11:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CO2PR07MB633E8089233A3B02B79D979931E0@CO2PR07MB633.namprd07.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428103347.GA7868@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lynnl.jr@outlook.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome