* Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement
[not found] <CO2PR07MB633E8089233A3B02B79D979931E0@CO2PR07MB633.namprd07.prod.outlook.com>
@ 2017-04-28 10:33 ` gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-04-28 10:33 UTC (permalink / raw)
To: Lynn Lei; +Cc: sudipm.mukherjee, devel, linux-fbdev, teddy.wang, linux-kernel
On Tue, Apr 25, 2017 at 03:53:02PM +0000, Lynn Lei wrote:
> Combine two separate set GPIO(30 & 31) operations into one statement.
Why?
>
> Signed-off-by: Lynn Lei <lynnl.jr@outlook.com>
> ---
> drivers/staging/sm750fb/ddk750_hwi2c.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
> index 68716ef7cb06..ddb7a6dc265a 100644
> --- a/drivers/staging/sm750fb/ddk750_hwi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c
> @@ -49,8 +49,7 @@ void sm750_hw_i2c_close(void)
>
> /* Set GPIO 30 & 31 back as GPIO pins */
> value = peek32(GPIO_MUX);
> - value &= ~GPIO_MUX_30;
> - value &= ~GPIO_MUX_31;
> + value &= ~(GPIO_MUX_30 | GPIO_MUX_31);
Why does this matter?
thanks,
greg k-h
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-04-28 11:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CO2PR07MB633E8089233A3B02B79D979931E0@CO2PR07MB633.namprd07.prod.outlook.com>
2017-04-28 10:33 ` [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome