mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Guru Das Srinagesh <gurooodas@gmail.com>
Cc: groeck@chromium.org, gregkh@linuxfoundation.org,
	heikki.krogerus@linux.intel.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: typec: Make undeclared symbol static
Date: Tue, 9 May 2017 09:04:41 -0700	[thread overview]
Message-ID: <20170509160441.GA14061@roeck-us.net> (raw)
In-Reply-To: <1494319733-28375-1-git-send-email-gurooodas@gmail.com>

On Tue, May 09, 2017 at 01:48:53AM -0700, Guru Das Srinagesh wrote:
> Fix sparse warning:
>   drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config'
>   was not declared. Should it be static?
> 
> Signed-off-by: Guru Das Srinagesh <gurooodas@gmail.com>

Olivier Leveque already sent a similar patch last week.

Thanks,
Guenter

> ---
>  drivers/staging/typec/tcpci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
> index 5e5be74..df72d8b 100644
> --- a/drivers/staging/typec/tcpci.c
> +++ b/drivers/staging/typec/tcpci.c
> @@ -425,7 +425,7 @@ static const struct regmap_config tcpci_regmap_config = {
>  	.max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */
>  };
>  
> -const struct tcpc_config tcpci_tcpc_config = {
> +static const struct tcpc_config tcpci_tcpc_config = {
>  	.type = TYPEC_PORT_DFP,
>  	.default_role = TYPEC_SINK,
>  };
> -- 
> 2.7.4
> 

      reply	other threads:[~2017-05-09 16:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09  8:48 Guru Das Srinagesh
2017-05-09 16:04 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170509160441.GA14061@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@chromium.org \
    --cc=gurooodas@gmail.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®