* [PATCH] staging: typec: Make undeclared symbol static
@ 2017-05-09 8:48 Guru Das Srinagesh
2017-05-09 16:04 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Guru Das Srinagesh @ 2017-05-09 8:48 UTC (permalink / raw)
To: linux, groeck, gregkh, heikki.krogerus; +Cc: devel, linux-kernel
Fix sparse warning:
drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config'
was not declared. Should it be static?
Signed-off-by: Guru Das Srinagesh <gurooodas@gmail.com>
---
drivers/staging/typec/tcpci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 5e5be74..df72d8b 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c
@@ -425,7 +425,7 @@ static const struct regmap_config tcpci_regmap_config = {
.max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */
};
-const struct tcpc_config tcpci_tcpc_config = {
+static const struct tcpc_config tcpci_tcpc_config = {
.type = TYPEC_PORT_DFP,
.default_role = TYPEC_SINK,
};
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: typec: Make undeclared symbol static
2017-05-09 8:48 [PATCH] staging: typec: Make undeclared symbol static Guru Das Srinagesh
@ 2017-05-09 16:04 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-05-09 16:04 UTC (permalink / raw)
To: Guru Das Srinagesh; +Cc: groeck, gregkh, heikki.krogerus, devel, linux-kernel
On Tue, May 09, 2017 at 01:48:53AM -0700, Guru Das Srinagesh wrote:
> Fix sparse warning:
> drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config'
> was not declared. Should it be static?
>
> Signed-off-by: Guru Das Srinagesh <gurooodas@gmail.com>
Olivier Leveque already sent a similar patch last week.
Thanks,
Guenter
> ---
> drivers/staging/typec/tcpci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
> index 5e5be74..df72d8b 100644
> --- a/drivers/staging/typec/tcpci.c
> +++ b/drivers/staging/typec/tcpci.c
> @@ -425,7 +425,7 @@ static const struct regmap_config tcpci_regmap_config = {
> .max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */
> };
>
> -const struct tcpc_config tcpci_tcpc_config = {
> +static const struct tcpc_config tcpci_tcpc_config = {
> .type = TYPEC_PORT_DFP,
> .default_role = TYPEC_SINK,
> };
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-09 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-09 8:48 [PATCH] staging: typec: Make undeclared symbol static Guru Das Srinagesh
2017-05-09 16:04 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®