mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: alexander.levin@verizon.com
To: "mingo@kernel.org" <mingo@kernel.org>
Cc: "ben@decadent.org.uk" <ben@decadent.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 04/15] liblockdep: Enable -Wall by default
Date: Thu, 18 May 2017 00:01:44 +0000	[thread overview]
Message-ID: <20170518000231.16163-4-alexander.levin@verizon.com> (raw)
In-Reply-To: <20170518000231.16163-1-alexander.levin@verizon.com>

From: Ben Hutchings <ben@decadent.org.uk>

Regressions in liblockdep may be missed because it doesn't enable
warnings.

Adding -Wall immediately introduces a lot of warnings, but those will
be fixed by the following commits.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
 tools/lib/lockdep/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
index 3bc0ef9f8923..98d8a5ae8334 100644
--- a/tools/lib/lockdep/Makefile
+++ b/tools/lib/lockdep/Makefile
@@ -79,6 +79,7 @@ INCLUDES = -I. -I./uinclude -I./include -I../../include $(CONFIG_INCLUDES)
 # Set compile option CFLAGS if not set elsewhere
 CFLAGS ?= -g -DCONFIG_LOCKDEP -DCONFIG_STACKTRACE -DCONFIG_PROVE_LOCKING -DBITS_PER_LONG=__WORDSIZE -DLIBLOCKDEP_VERSION='"$(LIBLOCKDEP_VERSION)"' -rdynamic -O0 -g
 CFLAGS += -fPIC
+CFLAGS += -Wall
 
 override CFLAGS += $(CONFIG_FLAGS) $(INCLUDES) $(PLUGIN_DIR_SQ)
 
-- 
2.11.0

  parent reply	other threads:[~2017-05-18  0:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18  0:01 [PATCH 01/15] liblockdep: Fix undefined symbol prandom_u32 alexander.levin
2017-05-18  0:01 ` [PATCH 03/15] liblockdep: Define the ARRAY_SIZE() macro alexander.levin
2017-05-18  0:01 ` alexander.levin [this message]
2017-05-18  0:01 ` [PATCH 02/15] liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth alexander.levin
2017-05-18  0:01 ` [PATCH 07/15] liblockdep: Fix 'defined but not used' warning for init_utsname() alexander.levin
2017-05-18  0:01 ` [PATCH 05/15] liblockdep: Fix 'unused value' warnings alexander.levin
2017-05-18  0:01 ` [PATCH 06/15] liblockdep: Fix 'set but not used' warnings alexander.levin
2017-05-18  0:01 ` [PATCH 10/15] tools: add install make target for liblockdep alexander.levin
2017-05-18  0:01 ` [PATCH 08/15] liblockdep: Remove -lpthread compiler option alexander.levin
2017-05-18  0:01 ` [PATCH 09/15] MAINTAINERS: update email for Sasha Levin alexander.levin
2017-05-18  0:01 ` [PATCH 11/15] tools: liblockdep: Don't mix fd-based and stream IO alexander.levin
2017-05-18  0:01 ` [PATCH 12/15] tools: liblockdep: fix compilation for 4.11 alexander.levin
2017-05-18  0:01 ` [PATCH 14/15] tools: liblockdep: Remove double-quotes from soname alexander.levin
2017-05-18  0:01 ` [PATCH 15/15] tools: liblockdep: Use LDFLAGS alexander.levin
2017-05-18  0:01 ` [PATCH 13/15] tools: liblockdep: Fix object file paths used in an out-of-tree build alexander.levin
2017-05-24  7:53 ` [PATCH 01/15] liblockdep: Fix undefined symbol prandom_u32 Ingo Molnar
2017-05-25 12:34   ` Levin, Alexander (Sasha Levin)
2017-05-26  6:54     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170518000231.16163-4-alexander.levin@verizon.com \
    --to=alexander.levin@verizon.com \
    --cc=ben@decadent.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®