From: alexander.levin@verizon.com
To: "mingo@kernel.org" <mingo@kernel.org>
Cc: "ben@decadent.org.uk" <ben@decadent.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 07/15] liblockdep: Fix 'defined but not used' warning for init_utsname()
Date: Thu, 18 May 2017 00:01:45 +0000 [thread overview]
Message-ID: <20170518000231.16163-7-alexander.levin@verizon.com> (raw)
In-Reply-To: <20170518000231.16163-1-alexander.levin@verizon.com>
From: Ben Hutchings <ben@decadent.org.uk>
We define init_utsname() as static but not inline, resulting
in a warning for every source file that includes lockdep.h but
doesn't call it.
Since it is only used by lockdep.c, define it in there.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
tools/lib/lockdep/lockdep.c | 10 ++++++++++
tools/lib/lockdep/uinclude/linux/lockdep.h | 10 ----------
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/tools/lib/lockdep/lockdep.c b/tools/lib/lockdep/lockdep.c
index 443acb11f907..209f967dedaa 100644
--- a/tools/lib/lockdep/lockdep.c
+++ b/tools/lib/lockdep/lockdep.c
@@ -12,4 +12,14 @@ u32 prandom_u32(void)
abort();
}
+static struct new_utsname *init_utsname(void)
+{
+ static struct new_utsname n = (struct new_utsname) {
+ .release = "liblockdep",
+ .version = LIBLOCKDEP_VERSION,
+ };
+
+ return &n;
+}
+
#include "../../../kernel/locking/lockdep.c"
diff --git a/tools/lib/lockdep/uinclude/linux/lockdep.h b/tools/lib/lockdep/uinclude/linux/lockdep.h
index d1079034a14d..c157242e0417 100644
--- a/tools/lib/lockdep/uinclude/linux/lockdep.h
+++ b/tools/lib/lockdep/uinclude/linux/lockdep.h
@@ -44,16 +44,6 @@ static inline int debug_locks_off(void)
#define atomic_t unsigned long
#define atomic_inc(x) ((*(x))++)
-static struct new_utsname *init_utsname(void)
-{
- static struct new_utsname n = (struct new_utsname) {
- .release = "liblockdep",
- .version = LIBLOCKDEP_VERSION,
- };
-
- return &n;
-}
-
#define print_tainted() ""
#define static_obj(x) 1
--
2.11.0
next prev parent reply other threads:[~2017-05-18 0:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 0:01 [PATCH 01/15] liblockdep: Fix undefined symbol prandom_u32 alexander.levin
2017-05-18 0:01 ` [PATCH 02/15] liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth alexander.levin
2017-05-18 0:01 ` [PATCH 03/15] liblockdep: Define the ARRAY_SIZE() macro alexander.levin
2017-05-18 0:01 ` [PATCH 04/15] liblockdep: Enable -Wall by default alexander.levin
2017-05-18 0:01 ` alexander.levin [this message]
2017-05-18 0:01 ` [PATCH 05/15] liblockdep: Fix 'unused value' warnings alexander.levin
2017-05-18 0:01 ` [PATCH 06/15] liblockdep: Fix 'set but not used' warnings alexander.levin
2017-05-18 0:01 ` [PATCH 09/15] MAINTAINERS: update email for Sasha Levin alexander.levin
2017-05-18 0:01 ` [PATCH 10/15] tools: add install make target for liblockdep alexander.levin
2017-05-18 0:01 ` [PATCH 08/15] liblockdep: Remove -lpthread compiler option alexander.levin
2017-05-18 0:01 ` [PATCH 11/15] tools: liblockdep: Don't mix fd-based and stream IO alexander.levin
2017-05-18 0:01 ` [PATCH 12/15] tools: liblockdep: fix compilation for 4.11 alexander.levin
2017-05-18 0:01 ` [PATCH 14/15] tools: liblockdep: Remove double-quotes from soname alexander.levin
2017-05-18 0:01 ` [PATCH 15/15] tools: liblockdep: Use LDFLAGS alexander.levin
2017-05-18 0:01 ` [PATCH 13/15] tools: liblockdep: Fix object file paths used in an out-of-tree build alexander.levin
2017-05-24 7:53 ` [PATCH 01/15] liblockdep: Fix undefined symbol prandom_u32 Ingo Molnar
2017-05-25 12:34 ` Levin, Alexander (Sasha Levin)
2017-05-26 6:54 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518000231.16163-7-alexander.levin@verizon.com \
--to=alexander.levin@verizon.com \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®