From: alexander.levin@verizon.com
To: "mingo@kernel.org" <mingo@kernel.org>
Cc: "ben@decadent.org.uk" <ben@decadent.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 06/15] liblockdep: Fix 'set but not used' warnings
Date: Thu, 18 May 2017 00:01:45 +0000 [thread overview]
Message-ID: <20170518000231.16163-6-alexander.levin@verizon.com> (raw)
In-Reply-To: <20170518000231.16163-1-alexander.levin@verizon.com>
From: Ben Hutchings <ben@decadent.org.uk>
liblockdep defines trivial macros for working with interrupt flags, as
interrupts are never disabled in userland. This results in warnings
from gcc when -Wunused-but-set-variable is enabled, and it is enabled
by -Wall. Fix this by evaluating the flags parameter and casting it to
void.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/lib/lockdep/uinclude/linux/irqflags.h b/tools/lib/lockdep/uinclude/linux/irqflags.h
index 6cc296f0fad0..df77669cfe1c 100644
--- a/tools/lib/lockdep/uinclude/linux/irqflags.h
+++ b/tools/lib/lockdep/uinclude/linux/irqflags.h
@@ -17,19 +17,19 @@
#define raw_local_irq_disable() do { } while (0)
#define raw_local_irq_enable() do { } while (0)
#define raw_local_irq_save(flags) ((flags) = 0)
-#define raw_local_irq_restore(flags) do { } while (0)
+#define raw_local_irq_restore(flags) ((void)(flags))
#define raw_local_save_flags(flags) ((flags) = 0)
-#define raw_irqs_disabled_flags(flags) do { } while (0)
+#define raw_irqs_disabled_flags(flags) ((void)(flags))
#define raw_irqs_disabled() 0
#define raw_safe_halt()
#define local_irq_enable() do { } while (0)
#define local_irq_disable() do { } while (0)
#define local_irq_save(flags) ((flags) = 0)
-#define local_irq_restore(flags) do { } while (0)
+#define local_irq_restore(flags) ((void)(flags))
#define local_save_flags(flags) ((flags) = 0)
#define irqs_disabled() (1)
-#define irqs_disabled_flags(flags) (0)
+#define irqs_disabled_flags(flags) ((void)(flags), 0)
#define safe_halt() do { } while (0)
#define trace_lock_release(x, y)
--
2.11.0
next prev parent reply other threads:[~2017-05-18 0:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 0:01 [PATCH 01/15] liblockdep: Fix undefined symbol prandom_u32 alexander.levin
2017-05-18 0:01 ` [PATCH 03/15] liblockdep: Define the ARRAY_SIZE() macro alexander.levin
2017-05-18 0:01 ` [PATCH 04/15] liblockdep: Enable -Wall by default alexander.levin
2017-05-18 0:01 ` [PATCH 02/15] liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth alexander.levin
2017-05-18 0:01 ` [PATCH 07/15] liblockdep: Fix 'defined but not used' warning for init_utsname() alexander.levin
2017-05-18 0:01 ` [PATCH 05/15] liblockdep: Fix 'unused value' warnings alexander.levin
2017-05-18 0:01 ` alexander.levin [this message]
2017-05-18 0:01 ` [PATCH 10/15] tools: add install make target for liblockdep alexander.levin
2017-05-18 0:01 ` [PATCH 08/15] liblockdep: Remove -lpthread compiler option alexander.levin
2017-05-18 0:01 ` [PATCH 09/15] MAINTAINERS: update email for Sasha Levin alexander.levin
2017-05-18 0:01 ` [PATCH 11/15] tools: liblockdep: Don't mix fd-based and stream IO alexander.levin
2017-05-18 0:01 ` [PATCH 12/15] tools: liblockdep: fix compilation for 4.11 alexander.levin
2017-05-18 0:01 ` [PATCH 14/15] tools: liblockdep: Remove double-quotes from soname alexander.levin
2017-05-18 0:01 ` [PATCH 13/15] tools: liblockdep: Fix object file paths used in an out-of-tree build alexander.levin
2017-05-18 0:01 ` [PATCH 15/15] tools: liblockdep: Use LDFLAGS alexander.levin
2017-05-24 7:53 ` [PATCH 01/15] liblockdep: Fix undefined symbol prandom_u32 Ingo Molnar
2017-05-25 12:34 ` Levin, Alexander (Sasha Levin)
2017-05-26 6:54 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518000231.16163-6-alexander.levin@verizon.com \
--to=alexander.levin@verizon.com \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®