* [PATCH] drm/i915/gvt: remove redundant -Wall
@ 2017-05-21 7:15 Nick Desaulniers
2017-05-29 20:01 ` Nick Desaulniers
2017-05-31 7:59 ` Zhenyu Wang
0 siblings, 2 replies; 3+ messages in thread
From: Nick Desaulniers @ 2017-05-21 7:15 UTC (permalink / raw)
Cc: Nick Desaulniers, Zhenyu Wang, Zhi Wang, Daniel Vetter,
Jani Nikula, David Airlie, intel-gvt-dev, intel-gfx, dri-devel,
linux-kernel
This flag is already set in the top level Makefile of the kernel.
Also, by having set CONFIG_DRM_I915_GVT, thereby appending -Wall to
ccflags, you undo all the -Wno-* cflags previously set in the Make
variable KBUILD_CFLAGS.
For example:
cc foo.c -Wall -Wno-format -Wall
resets -Wformat.
Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
I verified that -Wall was redundant by compiling with V=1:
make V=1 -j4 drivers/gpu/drm/i915/i915_gem_request.o
drivers/gpu/drm/i915/gvt/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile
index b123c20e2097..f5486cb94818 100644
--- a/drivers/gpu/drm/i915/gvt/Makefile
+++ b/drivers/gpu/drm/i915/gvt/Makefile
@@ -3,6 +3,6 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \
interrupt.o gtt.o cfg_space.o opregion.o mmio.o display.o edid.o \
execlist.o scheduler.o sched_policy.o render.o cmd_parser.o
-ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall
+ccflags-y += -I$(src) -I$(src)/$(GVT_DIR)
i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE))
obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/gvt: remove redundant -Wall
2017-05-21 7:15 [PATCH] drm/i915/gvt: remove redundant -Wall Nick Desaulniers
@ 2017-05-29 20:01 ` Nick Desaulniers
2017-05-31 7:59 ` Zhenyu Wang
1 sibling, 0 replies; 3+ messages in thread
From: Nick Desaulniers @ 2017-05-29 20:01 UTC (permalink / raw)
To: Zhenyu Wang, Zhi Wang, Daniel Vetter, Jani Nikula, David Airlie,
intel-gvt-dev, intel-gfx, dri-devel, linux-kernel
ping for review
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/gvt: remove redundant -Wall
2017-05-21 7:15 [PATCH] drm/i915/gvt: remove redundant -Wall Nick Desaulniers
2017-05-29 20:01 ` Nick Desaulniers
@ 2017-05-31 7:59 ` Zhenyu Wang
1 sibling, 0 replies; 3+ messages in thread
From: Zhenyu Wang @ 2017-05-31 7:59 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Zhi Wang, Daniel Vetter, Jani Nikula, David Airlie,
intel-gvt-dev, intel-gfx, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
On 2017.05.21 00:15:27 -0700, Nick Desaulniers wrote:
> This flag is already set in the top level Makefile of the kernel.
>
> Also, by having set CONFIG_DRM_I915_GVT, thereby appending -Wall to
> ccflags, you undo all the -Wno-* cflags previously set in the Make
> variable KBUILD_CFLAGS.
>
> For example:
>
> cc foo.c -Wall -Wno-format -Wall
>
> resets -Wformat.
>
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
> I verified that -Wall was redundant by compiling with V=1:
> make V=1 -j4 drivers/gpu/drm/i915/i915_gem_request.o
>
> drivers/gpu/drm/i915/gvt/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile
> index b123c20e2097..f5486cb94818 100644
> --- a/drivers/gpu/drm/i915/gvt/Makefile
> +++ b/drivers/gpu/drm/i915/gvt/Makefile
> @@ -3,6 +3,6 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \
> interrupt.o gtt.o cfg_space.o opregion.o mmio.o display.o edid.o \
> execlist.o scheduler.o sched_policy.o render.o cmd_parser.o
>
> -ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall
> +ccflags-y += -I$(src) -I$(src)/$(GVT_DIR)
> i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE))
> obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o
> --
Pushed, thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-31 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-21 7:15 [PATCH] drm/i915/gvt: remove redundant -Wall Nick Desaulniers
2017-05-29 20:01 ` Nick Desaulniers
2017-05-31 7:59 ` Zhenyu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®