From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Wei-Ning Huang <wnhuang@google.com>,
Julius Werner <jwerner@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/8] firmware: vpd: avoid potential use-after-free when destroying section
Date: Tue, 23 May 2017 17:07:43 -0700 [thread overview]
Message-ID: <20170524000748.39310-3-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20170524000748.39310-1-dmitry.torokhov@gmail.com>
We should not free info->key before we remove sysfs attribute that uses
this data as its name.
Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/firmware/google/vpd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index acf3f3cdc3f8..b3a6e918418b 100644
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -157,8 +157,8 @@ static void vpd_section_attrib_destroy(struct vpd_section *sec)
struct vpd_attrib_info *temp;
list_for_each_entry_safe(info, temp, &sec->attribs, list) {
- kfree(info->key);
sysfs_remove_bin_file(sec->kobj, &info->bin_attr);
+ kfree(info->key);
kfree(info);
}
}
--
2.13.0.219.gdb65acc882-goog
next prev parent reply other threads:[~2017-05-24 0:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 0:07 [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list Dmitry Torokhov
2017-05-24 0:07 ` [PATCH 2/8] firmware: vpd: use kdtrndup when copying section key Dmitry Torokhov
2017-05-24 17:13 ` Guenter Roeck
2017-05-24 0:07 ` Dmitry Torokhov [this message]
2017-05-24 17:15 ` [PATCH 3/8] firmware: vpd: avoid potential use-after-free when destroying section Guenter Roeck
2017-05-24 0:07 ` [PATCH 4/8] firmware: vpd: do not leak kobjects Dmitry Torokhov
2017-05-24 17:16 ` Guenter Roeck
2017-05-24 0:07 ` [PATCH 5/8] firmware: vpd: use kasprintf() when forming name of 'raw' attribute Dmitry Torokhov
2017-05-24 17:18 ` Guenter Roeck
2017-05-24 0:07 ` [PATCH 6/8] firmware: vpd: do not clear statically allocated data Dmitry Torokhov
2017-05-24 17:19 ` Guenter Roeck
2017-05-24 0:07 ` [PATCH 7/8] firmware: vpd: remove platform driver Dmitry Torokhov
2017-05-24 17:22 ` Guenter Roeck
2017-05-25 0:04 ` Julius Werner
2017-05-25 2:38 ` Dmitry Torokhov
2017-05-24 0:07 ` [PATCH 8/8] firmware: vpd: fix confusion between memremap and iounmap Dmitry Torokhov
2017-05-24 17:23 ` Guenter Roeck
2017-05-25 13:41 ` Greg Kroah-Hartman
2017-05-24 17:13 ` [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list Guenter Roeck
2017-05-25 13:40 ` Greg Kroah-Hartman
2017-05-25 16:35 ` Dmitry Torokhov
2017-05-25 16:50 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524000748.39310-3-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wnhuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome