mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Wei-Ning Huang <wnhuang@google.com>,
	Julius Werner <jwerner@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 4/8] firmware: vpd: do not leak kobjects
Date: Tue, 23 May 2017 17:07:44 -0700	[thread overview]
Message-ID: <20170524000748.39310-4-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20170524000748.39310-1-dmitry.torokhov@gmail.com>

kobject_del() only unlinks kobject, we need to use kobject_put() to
make sure kobject will go away completely.

Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/firmware/google/vpd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index b3a6e918418b..cb07a2984ece 100644
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -243,7 +243,7 @@ static int vpd_section_destroy(struct vpd_section *sec)
 {
 	if (sec->enabled) {
 		vpd_section_attrib_destroy(sec);
-		kobject_del(sec->kobj);
+		kobject_put(sec->kobj);
 		sysfs_remove_bin_file(vpd_kobj, &sec->bin_attr);
 		kfree(sec->raw_name);
 		iounmap(sec->baseaddr);
@@ -330,7 +330,7 @@ static void __exit vpd_platform_exit(void)
 {
 	vpd_section_destroy(&ro_vpd);
 	vpd_section_destroy(&rw_vpd);
-	kobject_del(vpd_kobj);
+	kobject_put(vpd_kobj);
 }
 
 module_init(vpd_platform_init);
-- 
2.13.0.219.gdb65acc882-goog

  parent reply	other threads:[~2017-05-24  0:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24  0:07 [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list Dmitry Torokhov
2017-05-24  0:07 ` [PATCH 2/8] firmware: vpd: use kdtrndup when copying section key Dmitry Torokhov
2017-05-24 17:13   ` Guenter Roeck
2017-05-24  0:07 ` [PATCH 3/8] firmware: vpd: avoid potential use-after-free when destroying section Dmitry Torokhov
2017-05-24 17:15   ` Guenter Roeck
2017-05-24  0:07 ` Dmitry Torokhov [this message]
2017-05-24 17:16   ` [PATCH 4/8] firmware: vpd: do not leak kobjects Guenter Roeck
2017-05-24  0:07 ` [PATCH 5/8] firmware: vpd: use kasprintf() when forming name of 'raw' attribute Dmitry Torokhov
2017-05-24 17:18   ` Guenter Roeck
2017-05-24  0:07 ` [PATCH 6/8] firmware: vpd: do not clear statically allocated data Dmitry Torokhov
2017-05-24 17:19   ` Guenter Roeck
2017-05-24  0:07 ` [PATCH 7/8] firmware: vpd: remove platform driver Dmitry Torokhov
2017-05-24 17:22   ` Guenter Roeck
2017-05-25  0:04     ` Julius Werner
2017-05-25  2:38       ` Dmitry Torokhov
2017-05-24  0:07 ` [PATCH 8/8] firmware: vpd: fix confusion between memremap and iounmap Dmitry Torokhov
2017-05-24 17:23   ` Guenter Roeck
2017-05-25 13:41   ` Greg Kroah-Hartman
2017-05-24 17:13 ` [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list Guenter Roeck
2017-05-25 13:40 ` Greg Kroah-Hartman
2017-05-25 16:35   ` Dmitry Torokhov
2017-05-25 16:50     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170524000748.39310-4-dmitry.torokhov@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@chromium.org \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wnhuang@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome