From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 2/4] perf/x86: Fix data source decoding for Skylake
Date: Fri, 9 Jun 2017 09:47:33 -0700 [thread overview]
Message-ID: <20170609164733.GB28361@tassilo.jf.intel.com> (raw)
In-Reply-To: <20170608200302.GC8337@worktop.programming.kicks-ass.net>
> > > So one thing we could do is add a mem_hops field and always set that,
> > > even for the old stuff. The old stuff will not know about that field and
> > > ignore the bits, but new stuff will then not need as many LVL bits.
> > >
> > That would be better than lvlx I think. I am guessing you're suggesting
> > an integer count here and not a bitmask. Right?
>
> Yah, 0 hops = local, etc..
This doesn't work on Skylake because it doesn't report the number of hops,
just remote or not.
Would need a wildcard entry, but that can as well be a separate bit.
That's what I did in the latest version of my patch.
-Andi
next prev parent reply other threads:[~2017-06-09 16:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 23:22 Fix Skylake PEBS data source for perf Andi Kleen
2017-06-07 23:22 ` [PATCH v2 1/4] perf/x86: Move Nehalem PEBS code to flag Andi Kleen
2017-06-07 23:22 ` [PATCH v2 2/4] perf/x86: Fix data source decoding for Skylake Andi Kleen
2017-06-08 8:15 ` Peter Zijlstra
2017-06-08 19:40 ` Stephane Eranian
2017-06-08 20:03 ` Peter Zijlstra
2017-06-09 16:47 ` Andi Kleen [this message]
2017-06-08 20:10 ` Andi Kleen
2017-06-08 20:22 ` Peter Zijlstra
2017-06-09 8:04 ` Madhavan Srinivasan
2017-06-07 23:22 ` [PATCH v2 3/4] perf, tools: Add support for printing new mem_info encodings Andi Kleen
2017-06-07 23:22 ` [PATCH v2 4/4] perf, tools: Add test cases for new data source encoding Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609164733.GB28361@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®