From: Ingo Molnar <mingo@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <mmarek@suse.com>,
x86@kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael Davidson <md@google.com>,
Greg Hackmann <ghackmann@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Stephen Hines <srhines@google.com>,
Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
Bernhard.Rosenkranzer@linaro.org,
Peter Foley <pefoley2@pefoley.com>,
Behan Webster <behanw@converseincode.com>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 0/3] x86: stack alignment for boot code and clang
Date: Tue, 13 Jun 2017 08:39:24 +0200 [thread overview]
Message-ID: <20170613063924.j5kmyrkmpsaykfsg@gmail.com> (raw)
In-Reply-To: <20170613005531.77656-1-mka@chromium.org>
* Matthias Kaehlcke <mka@chromium.org> wrote:
> This series fixes an issue with the stack of the x86 boot code not
> being aligned as intended. Further it adapts the Makefile to account
> for the fact that clang uses a different option to configure the
> stack alignment than gcc (-mstack-alignment=N vs
> -mpreferred-stack-boundary=N)
>
> Matthias Kaehlcke (3):
> kbuild: Add cc-option-no-kbuild macro
> x86/build: Use cc-option-no-kbuild for boot code compiler options
> x86/build: Specify stack alignment for clang
>
> arch/x86/Makefile | 25 +++++++++++++++++--------
> scripts/Kbuild.include | 5 +++++
> 2 files changed, 22 insertions(+), 8 deletions(-)
Looks good to me, modulo the minor comments I just made to the #3 patch.
This needs acks from the kbuild people before I can apply the fixes.
Thanks,
Ingo
prev parent reply other threads:[~2017-06-13 6:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 0:55 Matthias Kaehlcke
2017-06-13 0:55 ` [PATCH 1/3] kbuild: Add cc-option-no-kbuild macro Matthias Kaehlcke
2017-06-13 7:49 ` Michal Marek
2017-06-13 8:31 ` Arnd Bergmann
2017-06-13 10:13 ` Masahiro Yamada
2017-06-13 16:45 ` Matthias Kaehlcke
2017-06-13 0:55 ` [PATCH 2/3] x86/build: Use cc-option-no-kbuild for boot code compiler options Matthias Kaehlcke
2017-06-13 0:55 ` [PATCH 3/3] x86/build: Specify stack alignment for clang Matthias Kaehlcke
2017-06-13 6:38 ` Ingo Molnar
2017-06-13 17:25 ` Matthias Kaehlcke
2017-06-13 6:39 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613063924.j5kmyrkmpsaykfsg@gmail.com \
--to=mingo@kernel.org \
--cc=Bernhard.Rosenkranzer@linaro.org \
--cc=arnd@arndb.de \
--cc=behanw@converseincode.com \
--cc=dianders@chromium.org \
--cc=dwmw2@infradead.org \
--cc=ghackmann@google.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=mmarek@suse.com \
--cc=ndesaulniers@google.com \
--cc=pefoley2@pefoley.com \
--cc=srhines@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®