From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: sergey.senozhatsky.work@gmail.com, pmladek@suse.com,
sergey.senozhatsky@gmail.com, rostedt@goodmis.org, jack@suse.cz,
akpm@linux-foundation.org, peterz@infradead.org,
rjw@rjwysocki.net, ebiederm@xmission.com,
gregkh@linuxfoundation.org, jslaby@suse.com, pavel@ucw.cz,
andi@lisas.de, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCHv3 2/5] printk: introduce printing kernel thread
Date: Fri, 30 Jun 2017 20:57:11 +0900 [thread overview]
Message-ID: <20170630115710.GB474@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <201706301918.HFI17946.JtOFLOFQSHOMFV@I-love.SAKURA.ne.jp>
On (06/30/17 19:18), Tetsuo Handa wrote:
> Sergey Senozhatsky wrote:
> > if (!alloc_cpumask_var(&cpus_allowed, GFP_KERNEL)) {
> > wake_up_process(printk_kthread);
> > return true;
> > }
>
> Please avoid memory allocations when trying to print something.
> __GFP_DIRECT_RECLAIM allocations (e.g. GFP_KERNEL) can sleep for
> unpredictable duration. Allocations without __GFP_NOWARN will cause
> e.g. memory allocation failure messages. Even with __GFP_NOWARN,
> some messages might be still printed (e.g. serious problem).
wow... dammit, what a stupid mistake. you are 100% right, thanks!
it's sooo unsafe and dumb, console_unlock() and, thus, offloading
can happen from IRQ.
thanks again.
> > I'm still thinking about Steven's proposals; but we will need offloading
> > anyways, so the bits we are talking about here are important regardless
> > the direction printk design will take, I think.
>
> Is there a chance that printk() waits for only data queued by that printk()
> call (exception will be printk() from NMI).
hm, I don't think this can be done easily... consider
console_lock();
printk();
printk();
... -> this guys will wait forever. nothing
flushes the logbuf.
printk();
console_unlock();
> If we carry penalty for printk() (charge delay according to amount of
> data queued by that printk()), users will stop doing stupid flooding
> with printk() based on an assumption that offloaded kernel thread will
> manage magically with guarantee of being printed out (i.e. users has
> to become careful).
ratelimiting is on my list. but it's a bit tricky... what should happen
if one does
CPU1
-> IRQ
printk()
console_unlock();
printk()
console_unlock();
...
printk()
ratelimit();
console_unlock();
-> NMI panic()
need to think more.
-ss
next prev parent reply other threads:[~2017-06-30 11:57 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 8:28 [RFC][PATCHv3 0/5] " Sergey Senozhatsky
2017-05-09 8:28 ` [RFC][PATCHv3 1/5] printk: move printk_pending out of per-cpu Sergey Senozhatsky
2017-05-25 12:11 ` Petr Mladek
2017-05-25 12:36 ` Sergey Senozhatsky
2017-05-25 12:43 ` Petr Mladek
2017-05-09 8:28 ` [RFC][PATCHv3 2/5] printk: introduce printing kernel thread Sergey Senozhatsky
2017-05-10 5:59 ` Sergey Senozhatsky
2017-05-29 9:29 ` Petr Mladek
2017-05-29 12:12 ` Jan Kara
2017-05-31 7:30 ` Sergey Senozhatsky
2017-05-31 21:44 ` Andreas Mohr
2017-06-01 7:21 ` Sergey Senozhatsky
2017-06-01 7:23 ` Sergey Senozhatsky
2017-06-01 9:20 ` Sergey Senozhatsky
2017-06-28 13:17 ` Petr Mladek
2017-06-29 7:40 ` Sergey Senozhatsky
2017-06-28 12:45 ` Petr Mladek
2017-05-31 7:22 ` Sergey Senozhatsky
2017-06-28 12:19 ` Petr Mladek
2017-06-29 6:26 ` Andreas Mohr
2017-06-29 7:00 ` Andreas Mohr
2017-06-29 7:33 ` Sergey Senozhatsky
2017-06-29 11:24 ` Tetsuo Handa
2017-06-30 7:01 ` Sergey Senozhatsky
2017-06-30 10:18 ` Tetsuo Handa
2017-06-30 11:57 ` Sergey Senozhatsky [this message]
2017-06-30 12:35 ` Tetsuo Handa
2017-06-30 12:50 ` Sergey Senozhatsky
2017-06-30 13:16 ` Petr Mladek
2017-06-30 13:38 ` Sergey Senozhatsky
2017-07-03 11:11 ` Sergey Senozhatsky
2017-07-02 20:27 ` Pavel Machek
2017-07-05 16:36 ` Sergey Senozhatsky
2017-07-03 19:34 ` Steven Rostedt
2017-07-04 5:26 ` Sergey Senozhatsky
2017-07-04 6:53 ` Sergey Senozhatsky
2017-06-30 14:10 ` Sergey Senozhatsky
2017-06-30 11:54 ` Petr Mladek
2017-06-30 12:42 ` Sergey Senozhatsky
2017-06-30 13:33 ` Steven Rostedt
2017-06-30 14:28 ` Sergey Senozhatsky
2017-06-30 14:45 ` Steven Rostedt
2017-07-01 1:50 ` Sergey Senozhatsky
2017-07-04 14:03 ` Petr Mladek
2017-07-05 5:02 ` Sergey Senozhatsky
2017-05-09 8:28 ` [RFC][PATCHv3 3/5] printk: add enforce_emergency parameter Sergey Senozhatsky
2017-05-09 8:28 ` [RFC][PATCHv3 4/5] printk: enable printk offloading Sergey Senozhatsky
2017-05-09 8:28 ` [RFC][PATCHv3 5/5] printk: register PM notifier Sergey Senozhatsky
2017-05-30 9:55 ` Petr Mladek
2017-05-31 6:42 ` Sergey Senozhatsky
2017-06-27 14:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630115710.GB474@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@lisas.de \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®