mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mfd: Add missing Kconfig dependency for TPS65086
@ 2017-07-13  9:01 Michal Simek
  2017-07-17  7:59 ` Lee Jones
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2017-07-13  9:01 UTC (permalink / raw)
  To: linux-kernel, monstr; +Cc: Lee Jones

MTF_CORE should be enabled when driver is enabled.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 94ad2c1c3d90..f98b5a6d4da8 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1294,6 +1294,7 @@ config TPS6507X
 
 config MFD_TPS65086
 	tristate "TI TPS65086 Power Management Integrated Chips (PMICs)"
+	select MFD_CORE
 	select REGMAP
 	select REGMAP_IRQ
 	select REGMAP_I2C
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: Add missing Kconfig dependency for TPS65086
  2017-07-13  9:01 [PATCH] mfd: Add missing Kconfig dependency for TPS65086 Michal Simek
@ 2017-07-17  7:59 ` Lee Jones
  2017-07-17  8:00   ` Michal Simek
  0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2017-07-17  7:59 UTC (permalink / raw)
  To: Michal Simek; +Cc: linux-kernel, monstr

On Thu, 13 Jul 2017, Michal Simek wrote:

> MTF_CORE should be enabled when driver is enabled.

"MFD_CORE"

You also need more information here.  Why is it required?  What
happens if it's not specified?  Etc.

> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 94ad2c1c3d90..f98b5a6d4da8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1294,6 +1294,7 @@ config TPS6507X
>  
>  config MFD_TPS65086
>  	tristate "TI TPS65086 Power Management Integrated Chips (PMICs)"
> +	select MFD_CORE
>  	select REGMAP
>  	select REGMAP_IRQ
>  	select REGMAP_I2C

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: Add missing Kconfig dependency for TPS65086
  2017-07-17  7:59 ` Lee Jones
@ 2017-07-17  8:00   ` Michal Simek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2017-07-17  8:00 UTC (permalink / raw)
  To: Lee Jones, Michal Simek; +Cc: linux-kernel, monstr

On 17.7.2017 09:59, Lee Jones wrote:
> On Thu, 13 Jul 2017, Michal Simek wrote:
> 
>> MTF_CORE should be enabled when driver is enabled.
> 
> "MFD_CORE"
> 
> You also need more information here.  Why is it required?  What
> happens if it's not specified?  Etc.

There is compilation warning. Fair enough. I will send v2 with update log.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-17  8:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-13  9:01 [PATCH] mfd: Add missing Kconfig dependency for TPS65086 Michal Simek
2017-07-17  7:59 ` Lee Jones
2017-07-17  8:00   ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®