[PATCH 0/4] Add various TI-SCI DT nodes on 66AK2G SoCs

[PATCH 0/4] Add various TI-SCI DT nodes on 66AK2G SoCs

[Suman Anna]

Hi Santosh,

The following patch series adds various TI-SCI related DTS nodes that
probe the corresponding TI-SCI genpd, clock and reset drivers for the
66AK2G platforms.

This is the second of two series, and these nodes along with the defconfig
patches finally allows adding other peripherals to the 66AK2G platforms.
All the new peripherals should/will be added without using the device id
macros [1]. Patches are baselined on 4.13-rc1 and are intended for the 4.14
merge window.

I have boot-tested both the series individually and combined on all
the Keystone2 platforms. K2G platforms are boot-tested using ramdisk,
the MMC boot and NFS boot can be enabled once the corresponding DTS nodes
are added. The addition of the PMMC node also enables the system reboot.

regards
Suman

[1] https://patchwork.kernel.org/patch/9741279/

Andrew F. Davis (1):
  ARM: dts: keystone-k2g: Add TI SCI reset-controller node

Dave Gerlach (1):
  ARM: dts: keystone-k2g: Add ti-sci power domain node

Nishanth Menon (1):
  ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

Tero Kristo (1):
  ARM: dts: keystone-k2g: Add ti-sci clock provider node

 arch/arm/boot/dts/keystone-k2g.dtsi | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

-- 
2.13.1

[PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

[Suman Anna]

From: Nishanth Menon <nm@ti.com>

Texas Instrument's System Control Interface (TI-SCI) Message Protocol
is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.

Add the ti-sci node representing this 66AK2G PMMC module.

Signed-off-by: Nishanth Menon <nm@ti.com>
[s-anna@ti.com: add unit address to DT node]
Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index a789f75a1ed5..7f0f4180b373 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -139,5 +139,19 @@
 			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
 		};
+
+		pmmc: pmmc@02921c00 {
+			compatible = "ti,k2g-sci";
+			/*
+			 * In case of rare platforms that does not use k2g as
+			 * system master, use /delete-property/
+			 */
+			ti,system-reboot-controller;
+			mbox-names = "rx", "tx";
+			mboxes= <&msgmgr 5 2>,
+				<&msgmgr 0 0>;
+			reg-names = "debug_messages";
+			reg = <0x02921c00 0x400>;
+		};
 	};
 };
-- 
2.13.1

Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

[Andrew F. Davis]

On 07/17/2017 10:28 PM, Suman Anna wrote:
> From: Nishanth Menon <nm@ti.com>
> 
> Texas Instrument's System Control Interface (TI-SCI) Message Protocol
> is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.
> 
> Add the ti-sci node representing this 66AK2G PMMC module.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> [s-anna@ti.com: add unit address to DT node]
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>  arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
> index a789f75a1ed5..7f0f4180b373 100644
> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
> @@ -139,5 +139,19 @@
>  			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
>  				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
>  		};
> +
> +		pmmc: pmmc@02921c00 {
> +			compatible = "ti,k2g-sci";
> +			/*
> +			 * In case of rare platforms that does not use k2g as
> +			 * system master, use /delete-property/
> +			 */

This comment seems mis-worded, I believe this was meant to say "for
platforms that do not use the *PMMC* as the system master".

Andrew

> +			ti,system-reboot-controller;
> +			mbox-names = "rx", "tx";
> +			mboxes= <&msgmgr 5 2>,
> +				<&msgmgr 0 0>;
> +			reg-names = "debug_messages";
> +			reg = <0x02921c00 0x400>;
> +		};
>  	};
>  };
> 

Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

[Suman Anna]

On 07/18/2017 10:00 AM, Andrew F. Davis wrote:
> On 07/17/2017 10:28 PM, Suman Anna wrote:
>> From: Nishanth Menon <nm@ti.com>
>>
>> Texas Instrument's System Control Interface (TI-SCI) Message Protocol
>> is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.
>>
>> Add the ti-sci node representing this 66AK2G PMMC module.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> [s-anna@ti.com: add unit address to DT node]
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>>  arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
>> index a789f75a1ed5..7f0f4180b373 100644
>> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
>> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
>> @@ -139,5 +139,19 @@
>>  			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
>>  				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
>>  		};
>> +
>> +		pmmc: pmmc@02921c00 {
>> +			compatible = "ti,k2g-sci";
>> +			/*
>> +			 * In case of rare platforms that does not use k2g as
>> +			 * system master, use /delete-property/
>> +			 */
> 
> This comment seems mis-worded, I believe this was meant to say "for
> platforms that do not use the *PMMC* as the system master".

The comment is for the system-reboot-controller property, and is meant
to say that this property is to be deleted from this node if there is an
external entity on the board other than the K2G SoC that is responsible
for triggering a reboot.

regards
Suman

> 
> Andrew
> 
>> +			ti,system-reboot-controller;
>> +			mbox-names = "rx", "tx";
>> +			mboxes= <&msgmgr 5 2>,
>> +				<&msgmgr 0 0>;
>> +			reg-names = "debug_messages";
>> +			reg = <0x02921c00 0x400>;
>> +		};
>>  	};
>>  };
>>

Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

[Andrew F. Davis]

On 07/18/2017 06:50 PM, Suman Anna wrote:
> On 07/18/2017 10:00 AM, Andrew F. Davis wrote:
>> On 07/17/2017 10:28 PM, Suman Anna wrote:
>>> From: Nishanth Menon <nm@ti.com>
>>>
>>> Texas Instrument's System Control Interface (TI-SCI) Message Protocol
>>> is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.
>>>
>>> Add the ti-sci node representing this 66AK2G PMMC module.
>>>
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>> [s-anna@ti.com: add unit address to DT node]
>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>> ---
>>>  arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
>>> index a789f75a1ed5..7f0f4180b373 100644
>>> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
>>> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
>>> @@ -139,5 +139,19 @@
>>>  			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
>>>  				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
>>>  		};
>>> +
>>> +		pmmc: pmmc@02921c00 {
>>> +			compatible = "ti,k2g-sci";
>>> +			/*
>>> +			 * In case of rare platforms that does not use k2g as
>>> +			 * system master, use /delete-property/
>>> +			 */
>>
>> This comment seems mis-worded, I believe this was meant to say "for
>> platforms that do not use the *PMMC* as the system master".
> 
> The comment is for the system-reboot-controller property, and is meant
> to say that this property is to be deleted from this node if there is an
> external entity on the board other than the K2G SoC that is responsible
> for triggering a reboot.
> 

I see, that makes more sense, thanks for the clarification.

Andrew

> regards
> Suman
> 
>>
>> Andrew
>>
>>> +			ti,system-reboot-controller;
>>> +			mbox-names = "rx", "tx";
>>> +			mboxes= <&msgmgr 5 2>,
>>> +				<&msgmgr 0 0>;
>>> +			reg-names = "debug_messages";
>>> +			reg = <0x02921c00 0x400>;
>>> +		};
>>>  	};
>>>  };
>>>
> 

[PATCH 2/4] ARM: dts: keystone-k2g: Add ti-sci power domain node

[Suman Anna]

From: Dave Gerlach <d-gerlach@ti.com>

Add a ti-sci k2g_pds node to act as our generic power domain provider
in the system.

Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/boot/dts/keystone-k2g.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index 7f0f4180b373..7ffd7facdc47 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -152,6 +152,11 @@
 				<&msgmgr 0 0>;
 			reg-names = "debug_messages";
 			reg = <0x02921c00 0x400>;
+
+			k2g_pds: power-controller {
+				compatible = "ti,sci-pm-domain";
+				#power-domain-cells = <1>;
+			};
 		};
 	};
 };
-- 
2.13.1

[PATCH 3/4] ARM: dts: keystone-k2g: Add ti-sci clock provider node

[Suman Anna]

From: Tero Kristo <t-kristo@ti.com>

Add a ti-sci node representing the clock provider in the system.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/boot/dts/keystone-k2g.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index 7ffd7facdc47..2cdc7c8aeb5c 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -157,6 +157,11 @@
 				compatible = "ti,sci-pm-domain";
 				#power-domain-cells = <1>;
 			};
+
+			k2g_clks: clocks {
+				compatible = "ti,k2g-sci-clk";
+				#clock-cells = <2>;
+			};
 		};
 	};
 };
-- 
2.13.1

[PATCH 4/4] ARM: dts: keystone-k2g: Add TI SCI reset-controller node

[Suman Anna]

From: "Andrew F. Davis" <afd@ti.com>

Add a reset-controller node for managing resets of various
remote processor devices on the SoC over the Texas Instrument's
System Control Interface (TI SCI) protocol.

Signed-off-by: Andrew F. Davis <afd@ti.com>
[s-anna@ti.com: rename node name, drop obsolete header]
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/boot/dts/keystone-k2g.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index 2cdc7c8aeb5c..bf4d1fa30840 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -162,6 +162,11 @@
 				compatible = "ti,k2g-sci-clk";
 				#clock-cells = <2>;
 			};
+
+			k2g_reset: reset-controller {
+				compatible = "ti,sci-reset";
+				#reset-cells = <2>;
+			};
 		};
 	};
 };
-- 
2.13.1

Re: [PATCH 0/4] Add various TI-SCI DT nodes on 66AK2G SoCs

[santosh.shilimkar]

On 7/17/17 8:28 PM, Suman Anna wrote:
> Hi Santosh,
> 
> The following patch series adds various TI-SCI related DTS nodes that
> probe the corresponding TI-SCI genpd, clock and reset drivers for the
> 66AK2G platforms.
> 
> This is the second of two series, and these nodes along with the defconfig
> patches finally allows adding other peripherals to the 66AK2G platforms.
> All the new peripherals should/will be added without using the device id
> macros [1]. Patches are baselined on 4.13-rc1 and are intended for the 4.14
> merge window.
> 
And this one looks good as well. Please ping me if you don't see this 
show up in next, by next week.

Regards,
Santosh