* [PATCH] tracing: missing error code in tracer_alloc_buffers()
@ 2017-08-01 11:02 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-08-01 11:02 UTC (permalink / raw)
To: Steven Rostedt, Sebastian Andrzej Siewior
Cc: Ingo Molnar, linux-kernel, kernel-janitors
If ring_buffer_alloc() or one of the next couple function calls fail
then we should return -ENOMEM but the current code returns success.
Fixes: b32614c03413 ('tracing/rb: Convert to hotplug state machine')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 42b9355033d4..625c00aab800 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -8293,6 +8293,7 @@ __init static int tracer_alloc_buffers(void)
if (ret < 0)
goto out_free_cpumask;
/* Used for event triggers */
+ ret = -ENOMEM;
temp_buffer = ring_buffer_alloc(PAGE_SIZE, RB_FL_OVERWRITE);
if (!temp_buffer)
goto out_rm_hp_state;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-08-01 11:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-01 11:02 [PATCH] tracing: missing error code in tracer_alloc_buffers() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®