mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Wei Xu <xuwei5@hisilicon.com>,
	James Hogan <james.hogan@imgtec.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Kevin Cernekee <cernekee@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Matt Redfearn <matt.redfearn@imgtec.com>
Subject: [PATCH 05/12] irqchip/gic-v3-its: Report that effective affinity is a single target
Date: Tue, 15 Aug 2017 12:34:40 +0100	[thread overview]
Message-ID: <20170815113447.14507-6-marc.zyngier@arm.com> (raw)
In-Reply-To: <20170815113447.14507-1-marc.zyngier@arm.com>

The GICv3 ITS driver only targets a single CPU at a time, even if
the notional affinity is wider. Let's inform the core code
about this.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 drivers/irqchip/irq-gic-v3-its.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 68932873eebc..22e228500357 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -649,6 +649,7 @@ static int its_set_affinity(struct irq_data *d, const struct cpumask *mask_val,
 		target_col = &its_dev->its->collections[cpu];
 		its_send_movi(its_dev, target_col, id);
 		its_dev->event_map.col_map[id] = cpu;
+		irq_data_update_effective_affinity(d, cpumask_of(cpu));
 	}
 
 	return IRQ_SET_MASK_OK_DONE;
@@ -1481,6 +1482,7 @@ static int its_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
 
 		irq_domain_set_hwirq_and_chip(domain, virq + i,
 					      hwirq, &its_irq_chip, its_dev);
+		irqd_set_single_target(irq_desc_get_irq_data(irq_to_desc(virq + i)));
 		pr_debug("ID:%d pID:%d vID:%d\n",
 			 (int)(hwirq - its_dev->event_map.lpi_base),
 			 (int) hwirq, virq + i);
@@ -1495,13 +1497,16 @@ static void its_irq_domain_activate(struct irq_domain *domain,
 	struct its_device *its_dev = irq_data_get_irq_chip_data(d);
 	u32 event = its_get_event_id(d);
 	const struct cpumask *cpu_mask = cpu_online_mask;
+	int cpu;
 
 	/* get the cpu_mask of local node */
 	if (its_dev->its->numa_node >= 0)
 		cpu_mask = cpumask_of_node(its_dev->its->numa_node);
 
 	/* Bind the LPI to the first possible CPU */
-	its_dev->event_map.col_map[event] = cpumask_first(cpu_mask);
+	cpu = cpumask_first(cpu_mask);
+	its_dev->event_map.col_map[event] = cpu;
+	irq_data_update_effective_affinity(d, cpumask_of(cpu));
 
 	/* Map the GIC IRQ and event to the device */
 	its_send_mapti(its_dev, d->hwirq, event);
-- 
2.11.0

  parent reply	other threads:[~2017-08-15 11:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 11:34 [PATCH 00/12] genirq/irqchip: Effective affinity fixups Marc Zyngier
2017-08-15 11:34 ` [PATCH 01/12] genirq: Restrict effective affinity to single-target interrupts Marc Zyngier
2017-08-15 12:01   ` Thomas Gleixner
2017-08-15 12:18     ` Marc Zyngier
2017-08-15 11:34 ` [PATCH 02/12] genirq/proc: Use the the accessor to report the effective affinity Marc Zyngier
2017-08-15 11:34 ` [PATCH 03/12] irqchip/gic: Report that effective affinity is a single target Marc Zyngier
2017-08-15 11:34 ` [PATCH 04/12] irqchip/gic-v3: " Marc Zyngier
2017-08-15 11:34 ` Marc Zyngier [this message]
2017-08-15 11:34 ` [PATCH 06/12] irqchip/armada-370-xp: " Marc Zyngier
2017-08-15 11:34 ` [PATCH 07/12] irqchip/bcm-6345-l1: " Marc Zyngier
2017-08-15 11:34 ` [PATCH 08/12] irqchip/bcm-7038-l1: " Marc Zyngier
2017-08-15 11:34 ` [PATCH 09/12] irqchip/metag-ext: " Marc Zyngier
2017-08-15 11:34 ` [PATCH 10/12] irqchip/hip04: " Marc Zyngier
2017-08-15 11:34 ` [PATCH 11/12] irqchip/mips-gic: " Marc Zyngier
2017-08-15 16:23   ` Paul Burton
2017-08-15 16:44     ` Marc Zyngier
2017-08-15 16:48       ` Paul Burton
2017-08-15 11:34 ` [PATCH 12/12] irqchip/xtensa-mx: " Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815113447.14507-6-marc.zyngier@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=andrew@lunn.ch \
    --cc=cernekee@gmail.com \
    --cc=chris@zankel.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=james.hogan@imgtec.com \
    --cc=jason@lakedaemon.net \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.redfearn@imgtec.com \
    --cc=paul.burton@imgtec.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®