mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Shurong Zhang <zhang_shurong@foxmail.com>
Cc: Jens Frederich <jfrederich@gmail.com>,
	Daniel Drake <dsd@laptop.org>,
	Jon Nettleton <jon.nettleton@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel <devel@driverdev.osuosl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: olpc_dcon: remove pointless debug printk in dcon_freeze_store()
Date: Thu, 24 Aug 2017 17:07:37 +0300	[thread overview]
Message-ID: <20170824140737.ke2ebr5u73jrm7qq@mwanda> (raw)
In-Reply-To: <599e6e01.c9d9540a.b4229.15c6SMTPIN_ADDED_BROKEN@mx.google.com>

On Thu, Aug 24, 2017 at 02:10:37PM +0800, Shurong Zhang wrote:
> This printk doesn't really add anything worthwhile.
> 
> Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..f9d9465 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,6 @@ static ssize_t dcon_freeze_store(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	pr_info("dcon_freeze_store: %lu\n", output);
>  

Delete a blank line as well.  We don't allow two blank lines in a row.

regards,
dan carpenter

           reply	other threads:[~2017-08-24 14:08 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <599e6e01.c9d9540a.b4229.15c6SMTPIN_ADDED_BROKEN@mx.google.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824140737.ke2ebr5u73jrm7qq@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dsd@laptop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jfrederich@gmail.com \
    --cc=jon.nettleton@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhang_shurong@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®