* Re: [PATCH v3] staging: olpc_dcon: remove pointless debug printk in dcon_freeze_store()
[not found] <599e6e01.c9d9540a.b4229.15c6SMTPIN_ADDED_BROKEN@mx.google.com>
@ 2017-08-24 14:07 ` Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-08-24 14:07 UTC (permalink / raw)
To: Shurong Zhang
Cc: Jens Frederich, Daniel Drake, Jon Nettleton, Greg Kroah-Hartman,
devel, linux-kernel
On Thu, Aug 24, 2017 at 02:10:37PM +0800, Shurong Zhang wrote:
> This printk doesn't really add anything worthwhile.
>
> Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..f9d9465 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,6 @@ static ssize_t dcon_freeze_store(struct device *dev,
> if (ret)
> return ret;
>
> - pr_info("dcon_freeze_store: %lu\n", output);
>
Delete a blank line as well. We don't allow two blank lines in a row.
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread