* [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST
@ 2017-08-28 9:49 Hannes Reinecke
2017-08-29 11:45 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2017-08-28 9:49 UTC (permalink / raw)
To: x86
Cc: Boris Petkov, Linux Kernel Mailinglist, Hannes Reinecke, Hannes Reinecke
When COMPILE_TEST is set we should be compiling 32-bit only
drivers and features (like ISA support etc), too.
After all, it's a compile test.
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 781521b7cf9e..df61bc37b1a2 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2548,7 +2548,7 @@ config ISA_DMA_API
Enables ISA-style DMA support for devices requiring such controllers.
If unsure, say Y.
-if X86_32
+if X86_32 || COMPILE_TEST
config ISA
bool "ISA support"
--
2.12.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST
2017-08-28 9:49 [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST Hannes Reinecke
@ 2017-08-29 11:45 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2017-08-29 11:45 UTC (permalink / raw)
To: Hannes Reinecke
Cc: x86, Boris Petkov, Linux Kernel Mailinglist, Hannes Reinecke
* Hannes Reinecke <hare@suse.de> wrote:
> When COMPILE_TEST is set we should be compiling 32-bit only
> drivers and features (like ISA support etc), too.
> After all, it's a compile test.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 781521b7cf9e..df61bc37b1a2 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2548,7 +2548,7 @@ config ISA_DMA_API
> Enables ISA-style DMA support for devices requiring such controllers.
> If unsure, say Y.
>
> -if X86_32
> +if X86_32 || COMPILE_TEST
>
> config ISA
> bool "ISA support"
This is almost certainly a bad idea: if it's a compile test, why not compile test
the 32-bit kernel, which will include these drivers?
These are drivers that have probably been ever been built in 64-bit mode, and now
an allmodconfig/allyesconfig will turn them on...
Thanks,
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-29 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 9:49 [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST Hannes Reinecke
2017-08-29 11:45 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®