* [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array
@ 2017-09-13 8:04 Allen Pais
2017-09-13 8:22 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Allen Pais @ 2017-09-13 8:04 UTC (permalink / raw)
To: linux-kernel; +Cc: mchehab, gregkh, linux-media, devel, Allen Pais
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
index e882b55..d822918 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
@@ -451,7 +451,7 @@ static enum ia_css_frame_format yuv422_copy_formats[] = {
IA_CSS_FRAME_FORMAT_YUYV
};
-#define array_length(array) (sizeof(array)/sizeof(array[0]))
+#define array_length(array) (ARRAY_SIZE(array))
/* Verify whether the selected output format is can be produced
* by the copy binary given the stream format.
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array
2017-09-13 8:04 [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array Allen Pais
@ 2017-09-13 8:22 ` Dan Carpenter
2017-09-13 8:39 ` Allen
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2017-09-13 8:22 UTC (permalink / raw)
To: Allen Pais; +Cc: linux-kernel, devel, gregkh, mchehab, linux-media
You need a changelog.
On Wed, Sep 13, 2017 at 01:34:39PM +0530, Allen Pais wrote:
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
> index e882b55..d822918 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
> @@ -451,7 +451,7 @@ static enum ia_css_frame_format yuv422_copy_formats[] = {
> IA_CSS_FRAME_FORMAT_YUYV
> };
>
> -#define array_length(array) (sizeof(array)/sizeof(array[0]))
> +#define array_length(array) (ARRAY_SIZE(array))
Just get rid of this array_length macro and use ARRAY_SIZE() directly.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array
2017-09-13 8:22 ` Dan Carpenter
@ 2017-09-13 8:39 ` Allen
2017-09-13 8:45 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Allen @ 2017-09-13 8:39 UTC (permalink / raw)
To: Dan Carpenter
Cc: linux-kernel, devel, Greg Kroah-Hartman, mchehab, linux-media
>>
>> -#define array_length(array) (sizeof(array)/sizeof(array[0]))
>> +#define array_length(array) (ARRAY_SIZE(array))
>
> Just get rid of this array_length macro and use ARRAY_SIZE() directly.
>
Sure.
- Allen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array
2017-09-13 8:39 ` Allen
@ 2017-09-13 8:45 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-09-13 8:45 UTC (permalink / raw)
To: Allen; +Cc: linux-kernel, devel, Greg Kroah-Hartman, mchehab, linux-media
Also change the subject prefix to: [media] atomisp: so it's:
Subject: [PATCH v2] [media] atomisp: Use ARRAY_SIZE() instead of open coding it
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-13 8:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-13 8:04 [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array Allen Pais
2017-09-13 8:22 ` Dan Carpenter
2017-09-13 8:39 ` Allen
2017-09-13 8:45 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®