* [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event
@ 2017-09-29 11:29 Jan Kiszka
2017-09-29 11:49 ` Jan Kiszka
2017-10-04 0:00 ` Steven Rostedt
0 siblings, 2 replies; 4+ messages in thread
From: Jan Kiszka @ 2017-09-29 11:29 UTC (permalink / raw)
To: Steven Rostedt, Linux Kernel Mailing List
From: Jan Kiszka <jan.kiszka@siemens.com>
Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
I didn't manage to test this so far, but this looked strange while
reading the code.
trace-view-store.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/trace-view-store.c b/trace-view-store.c
index 2ec52c8..f5d0a04 100644
--- a/trace-view-store.c
+++ b/trace-view-store.c
@@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
"pid");
store->sched_wakeup_new_event =
- pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
+ pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
if (store->sched_wakeup_new_event)
store->sched_wakeup_new_pid_field =
pevent_find_any_field(store->sched_wakeup_new_event,
--
2.12.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event
2017-09-29 11:29 [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event Jan Kiszka
@ 2017-09-29 11:49 ` Jan Kiszka
2017-09-29 13:01 ` Steven Rostedt
2017-10-04 0:00 ` Steven Rostedt
1 sibling, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2017-09-29 11:49 UTC (permalink / raw)
To: Steven Rostedt, Linux Kernel Mailing List
On 2017-09-29 13:29, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> I didn't manage to test this so far, but this looked strange while
> reading the code.
Now I found out how it is supposed to work and can confirm that this
patch fixes a real bug.
Jan
>
> trace-view-store.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace-view-store.c b/trace-view-store.c
> index 2ec52c8..f5d0a04 100644
> --- a/trace-view-store.c
> +++ b/trace-view-store.c
> @@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
> "pid");
>
> store->sched_wakeup_new_event =
> - pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
> + pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
> if (store->sched_wakeup_new_event)
> store->sched_wakeup_new_pid_field =
> pevent_find_any_field(store->sched_wakeup_new_event,
>
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event
2017-09-29 11:49 ` Jan Kiszka
@ 2017-09-29 13:01 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2017-09-29 13:01 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Linux Kernel Mailing List
On Fri, 29 Sep 2017 13:49:31 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-09-29 13:29, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >
> > I didn't manage to test this so far, but this looked strange while
> > reading the code.
>
> Now I found out how it is supposed to work and can confirm that this
> patch fixes a real bug.
>
Thanks Jan,
I'm currently at Kernel Recipes and my time for adding patches is
extremely limited while traveling. I'll hopefully be able to get to all
this next week.
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event
2017-09-29 11:29 [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event Jan Kiszka
2017-09-29 11:49 ` Jan Kiszka
@ 2017-10-04 0:00 ` Steven Rostedt
1 sibling, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2017-10-04 0:00 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Linux Kernel Mailing List
On Fri, 29 Sep 2017 13:29:16 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
Thanks, applied!
-- Steve
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> I didn't manage to test this so far, but this looked strange while
> reading the code.
>
> trace-view-store.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace-view-store.c b/trace-view-store.c
> index 2ec52c8..f5d0a04 100644
> --- a/trace-view-store.c
> +++ b/trace-view-store.c
> @@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
> "pid");
>
> store->sched_wakeup_new_event =
> - pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
> + pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
> if (store->sched_wakeup_new_event)
> store->sched_wakeup_new_pid_field =
> pevent_find_any_field(store->sched_wakeup_new_event,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-04 0:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-29 11:29 [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event Jan Kiszka
2017-09-29 11:49 ` Jan Kiszka
2017-09-29 13:01 ` Steven Rostedt
2017-10-04 0:00 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®